-
Notifications
You must be signed in to change notification settings - Fork 1
Fix AI search dialog hint text overlap with send button #281
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Changed hint text positioning from right-2 to right-12 - Provides adequate clearance for send button (40px + gap) - Ensures hint text remains visible with long prompts Co-Authored-By: penrique@agentuity.com <pedro.tma@gmail.com>
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
WalkthroughRefactored SearchInput layout and sizing: increased outer container min-height, introduced a two-layer wrapper around the textarea, moved and right-aligned the hint (non-absolute), and adjusted send button alignment; no event handlers, public exports, or textarea behavior changed. Changes
Sequence Diagram(s)N/A — no control-flow or feature-level interaction changes. Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
✨ Finishing Touches
🧪 Generate unit tests
Comment |
Deploying with
|
Status | Name | Latest Commit | Preview URL | Updated (UTC) |
---|---|---|---|---|
✅ Deployment successful! View logs |
docs | dbbb27c | Commit Preview URL Branch Preview URL |
Sep 06 2025, 05:49 PM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
components/CustomSearchDialog/SearchInput.tsx (2)
67-67
: Align units to avoid px/rem driftButton uses px (w-[40px]) while the new offset uses rem (right-12). Prefer rem for the button too so spacing scales consistently with root font size.
Apply this diff:
- className="h-[40px] w-[40px] bg-gray-800 hover:bg-gray-900 disabled:bg-gray-200 dark:disabled:bg-gray-700 disabled:text-gray-400 text-white text-sm rounded-lg transition-colors disabled:cursor-not-allowed flex items-center justify-center flex-shrink-0" + className="h-10 w-10 bg-gray-800 hover:bg-gray-900 disabled:bg-gray-200 dark:disabled:bg-gray-700 disabled:text-gray-400 text-white text-sm rounded-lg transition-colors disabled:cursor-not-allowed flex items-center justify-center flex-shrink-0"Also applies to: 75-75
68-69
: Optional: clarify shortcut behavior in the hintKey handler supports Shift+Enter for newline; consider reflecting that in the copy.
Apply this diff:
- Press Enter to send + Press Enter to send • Shift+Enter for newline
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
components/CustomSearchDialog/SearchInput.tsx
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Workers Builds: docs
🔇 Additional comments (1)
components/CustomSearchDialog/SearchInput.tsx (1)
67-67
: LGTM: updated offset resolves overlapUsing right-12 (3rem) provides the needed 40px button + 8px gap clearance. Looks good.
- Changed from absolute positioning to flex layout approach - Hint text now positioned as separate element below textarea - Text moves down with textarea expansion and stays at bottom - Resolves overlap issue when typing long prompts Co-Authored-By: penrique@agentuity.com <pedro.tma@gmail.com>
✅ Fix Implemented and WorkingI've successfully implemented the dynamic positioning fix for the hint text in the AI search dialog. The solution changed from absolute positioning to a flex layout approach where the hint text is positioned as a separate element below the textarea. Key Changes Made:
Screenshot - Fix Working Correctly:As you can see in the screenshot, the "Press Enter to send" text now appears at the bottom-right of the expanded textarea component and moves down with the content expansion, exactly as requested. The text is no longer overlapping with the send button or appearing in the middle of the expanded textarea. Testing Completed:✅ Tested with long prompts that cause textarea expansion The fix is ready for review and testing! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Fix AI search dialog hint text overlap with send button
Summary
Fixed the UI overlap issue where the "Press Enter to send" hint text was hidden by long prompts in the AI search dialog. Changed the hint text positioning from
right-2
toright-12
to provide adequate clearance for the send button (40px width + 8px gap).Review & Testing Checklist for Human
Notes
right-2
→right-12
)Summary by CodeRabbit