merge new #3
Open
merge new #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: B0go <victorbogo@icloud.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
* Remove tchannel and x/net/context * Update glide and Gopkg files * Pin zap back to 1.7 Signed-off-by: Yuri Shkuro <ys@uber.com>
* Fix throttler test by avoiding time.Sleep Signed-off-by: Isaac Hier <ihier@uber.com> * Synchronize test http handler Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
* Vendor Thrift 0.10 Signed-off-by: Yuri Shkuro <ys@uber.com> * Fix import paths during thrift gen Signed-off-by: Yuri Shkuro <ys@uber.com> * Remove thrift as dependency Signed-off-by: Yuri Shkuro <ys@uber.com> * Move to top folder so that it can be excluded from vet/lint Signed-off-by: Yuri Shkuro <ys@uber.com> * go fmt Signed-off-by: Yuri Shkuro <ys@uber.com> * Fix lint and fmt targets Signed-off-by: Yuri Shkuro <ys@uber.com> * Add readme Signed-off-by: Yuri Shkuro <ys@uber.com> * Cleanup makefile Signed-off-by: Yuri Shkuro <ys@uber.com> * Update dep Signed-off-by: Yuri Shkuro <ys@uber.com>
* Get rid of satori/go.uuid library Signed-off-by: Isaac Hier <ihier@uber.com> * Update glide and dep lock files Signed-off-by: Isaac Hier <ihier@uber.com>
Signed-off-by: Yuri Shkuro <ys@uber.com>
* Add an example for Zipkin B3 Propagator Signed-off-by: Kun Liu <liuk1991@sina.com> * optimize the example code Signed-off-by: Kun Liu <liuk1991@sina.com> * change the white space to tabs Signed-off-by: Kun Liu <liuk1991@sina.com> * change the white space to tabs for the old example Signed-off-by: Kun Liu <liuk1991@sina.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
Signed-off-by: Goutham Veeramachaneni <gouthamve@gmail.com>
… (#331) Signed-off-by: Michael Puncel <mpuncel@squareup.com>
Signed-off-by: Won Jun Jang <wjang@uber.com>
Signed-off-by: Won Jun Jang <wjang@uber.com>
Signed-off-by: Eundoo Song <eundoo.song@gmail.com>
Signed-off-by: Eundoo Song <eundoo.song@gmail.com>
* disable JAEGER_AGENT_XXX if JAEGER_ENDPOINT is set Signed-off-by: Eundoo Song <eundoo.song@gmail.com> * Replace fmt.Sprintf by obj.String() Signed-off-by: Eundoo Song <eundoo.song@gmail.com> * Fix typo Signed-off-by: Eundoo Song <eundoo.song@gmail.com> * Remove comment Signed-off-by: Eundoo Song <eundoo.song@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
* added unreleased Signed-off-by: Joe Elliott <number101010@gmail.com> * updated constants Signed-off-by: Joe Elliott <number101010@gmail.com>
This resolves #570 where HTTP spans were sent in batches of 1 instead of the documented default of 100. Signed-off-by: R. Aidan Campbell <aidan.campbell@aexp.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
…578) * Use http client with 10 second timeout Signed-off-by: Joe Elliott <number101010@gmail.com> * lint Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
Signed-off-by: Joe Elliott <number101010@gmail.com>
* Update vendored thrift to 0.12.0 Signed-off-by: nhatthm <nt@hellofresh.com> * Regenerate files Signed-off-by: nhatthm <nt@hellofresh.com> * Add context to codebase Signed-off-by: nhatthm <nt@hellofresh.com> * Bump to thrift 0.13.0 Signed-off-by: nhatthm <nt@hellofresh.com> * Bump Thrift to 0.14.1 Signed-off-by: nhatthm <nt@hellofresh.com> * Add missing files in vendored Thrift 0.14 Signed-off-by: nhatthm <nt@hellofresh.com> * Generate files with Thrift 0.14.1 Signed-off-by: nhatthm <nt@hellofresh.com> * Add context to read and write ops Signed-off-by: nhatthm <nt@hellofresh.com> * Update README.md Signed-off-by: nhatthm <nt@hellofresh.com>
Link to #584 Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: albertteoh <albert.teoh@logz.io>
Signed-off-by: Aaron Jheng <wentworth@outlook.com>
Signed-off-by: Aaron Jheng <wentworth@outlook.com>
Signed-off-by: Jeff Widman <jeff@jeffwidman.com>
Based on the openzipkin/b3-propagation specification, the SpanID and ParentSpanID are to be encoded as 16 lower-hex characters. #533 fixed this for TraceID, and fixed the SpanID.String() method, but did not update the Zipkin Propagator SpanID encoding. This fix uses SpanID.String() to ensure proper encoding of the SpanID and ParentSpandID within the Zipkin Propagator. Signed-off-by: Nathan Bowler <nzb301@psu.edu>
It's calling logger.Infof, but loggers already include a trailing newline where it's needed, so don't include our own. Signed-off-by: Wade Carpenter <wwade@users.noreply.github.com> Co-authored-by: Wade Carpenter <wwade@users.noreply.github.com>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Signed-off-by: Yuri Shkuro <github@ysh.us>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.