Skip to content

Conversation

nason
Copy link
Collaborator

@nason nason commented Jul 14, 2018

Follow up to #199 (comment) and #200

@ztanner I added a test case here to make sure non-async and async functions were being handled in awaitWith. What do you think?

Seems ok here, but I'm thinking that it may be worth running the bundled code in lib through some tests too

@coveralls
Copy link

coveralls commented Jul 14, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling 004a7f3 on nason:awaitWithAsyncFnTest into 85aa8fb on agraboso:next.

@nason nason merged commit 1ed4ab0 into agraboso:next Jul 14, 2018
@ztanner
Copy link
Contributor

ztanner commented Jul 14, 2018

Yeah I think the underlying problem is that the bundler is expecting the awaited function to be async, since the transpiled code tries to then it. In reality, not everyone has an async payload/meta function, so this would throw.

I think it'd be a good idea to run the tests through the bundled code, because then I think we'd see some of these use-cases fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants