Handle sync requests without await #95
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a common pattern that after dispatching a request, we set an
isFetching
flag in the reducer. This flag is used in the bailout function to prevent sending the same request before receiving a reply from the server.With the current implementation,
payload
andmeta
attributes can be promises / async functions that construct the attributes. This means that theREQUEST
action has to wait for these to return before dispatching. During this time, other API call actions might be dispatched, and these would check for the bailout flag before anyREQUEST
is fired and before the bailout flag is set in the state. This results in multiple calls at the same time and make the bailout function not very useful.This fix dispatches
REQUEST
actions with non-asyncpayload
andmeta
attributes synchronously, guaranteeing that the flag is set in the reducer before any other action is dispatched.