-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add sharing instructions and policy refresh #1784
Conversation
Images automagically compressed by Calibre's image-actions ✨ Compression reduced images by 24.3%, saving 15.05 KB.
901 images did not require optimisation. |
✔️ Deploy Preview for gis-utah-gov ready! 🔨 Explore the source changes: ad1d396 🔍 Inspect the deploy log: https://app.netlify.com/sites/gis-utah-gov/deploys/60e764c1fb1e7d00078d1022 😎 Browse the preview: https://deploy-preview-1784--gis-utah-gov.netlify.app |
✔️ Deploy Preview for gis-utah-gov ready! 🔨 Explore the source changes: c27efb2 🔍 Inspect the deploy log: https://app.netlify.com/sites/gis-utah-gov/deploys/611d829ed5fec30007259f23 😎 Browse the preview: https://deploy-preview-1784--gis-utah-gov.netlify.app |
ed4339f
to
35e0a6b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good. I'm excited to get this out there. I think once the question is answered we are good to go unless anyone else has concerns.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this week a good target to merge? |
I got caught up with sendgrid and supervisor. Yes, I'll try to get to this
in the next day or two.
…On Mon, Aug 16, 2021 at 7:17 PM steveoh ***@***.***> wrote:
Is this week a good target to merge?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1784 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJDGLXWM7MYZ2UFNEGQZ233T5G2DFANCNFSM5ABPJZSA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&utm_campaign=notification-email>
.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok @steveoh , one last question before we merge. Months ago I did a quick-and-dirty addition of the "Sharing" tab to the top navigation right after "Developer." Are there additional things we need to do to make that cleaner/more persistent (I'm remembering something about the colors underneath the "active" tab?) or should I just strip that for now and find somewhere else to link the sharing/
page from?
Let's strip it and put it somewhere else. The nav has mobile issues already and this addition makes it worse. |
Ok, who wants to be the magic approving review? |
Co-authored-by: Nathan Kota <nathankota@utah.gov>
cc9e300
to
c27efb2
Compare
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Ok, after much rebasing and re-editing here's a fresh look at the reworked sharing and policy pages as part of agrc/porter#87.
Goals: