-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cancelled SLEs ignored by get_handling_unit
#67
Conversation
agritheory
commented
Sep 6, 2023
•
edited
Loading
edited
- Feature working, design validated
- (corrected net qty) Tests pass
- There's a new overconsumption failure in another test, not sure if its related or is an artifact from a previous test
- Docs with screenshot of new cancellation workflow
get_handling_unit
Discussion in #65 should be resolved before merging. |
discovered a bug in HU generation with the to_handling_unit being reused
need to test entire workflow still
@HKuz Can you take a look at this one? To test cancellation workflow I was setting up a transfer stock entry: from beam.tests.test_handling_unit import *
test_stock_entry_material_transfer_for_manufacture()
frappe.db.commit() I still need to add to the docs to show the new recombine/ cancellation workflow. @Rgottsch1 I found the bug you were showing, the fix will be included when this is merged. |
@agritheory this looks good - two things I noticed, which may be by design but wanted to ask about:
|
@HKuz Ready for review |
get_handling_unit
get_handling_unit
@agritheory docs look good! |