Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cancelled SLEs ignored by get_handling_unit #67

Merged
merged 15 commits into from
Sep 27, 2023

Conversation

agritheory
Copy link
Owner

@agritheory agritheory commented Sep 6, 2023

  • Feature working, design validated
  • (corrected net qty) Tests pass
    • There's a new overconsumption failure in another test, not sure if its related or is an artifact from a previous test
  • Docs with screenshot of new cancellation workflow

@agritheory agritheory linked an issue Sep 7, 2023 that may be closed by this pull request
@agritheory agritheory changed the title fix: cancelled SLEs ignored by get_handling_unit Draft: cancelled SLEs ignored by get_handling_unit Sep 7, 2023
@agritheory agritheory changed the title Draft: cancelled SLEs ignored by get_handling_unit Draft: cancelled SLEs ignored by get_handling_unit Sep 7, 2023
@agritheory
Copy link
Owner Author

Discussion in #65 should be resolved before merging.

@agritheory
Copy link
Owner Author

@HKuz Can you take a look at this one? To test cancellation workflow I was setting up a transfer stock entry:

from beam.tests.test_handling_unit import *
test_stock_entry_material_transfer_for_manufacture()
frappe.db.commit()

I still need to add to the docs to show the new recombine/ cancellation workflow.

@Rgottsch1 I found the bug you were showing, the fix will be included when this is merged.

@HKuz
Copy link
Collaborator

HKuz commented Sep 18, 2023

@agritheory this looks good - two things I noticed, which may be by design but wanted to ask about:

  • for items where the entire quantity of the existing HU that are transferred, a new HU is being created (for the test example, the Limequat and Kaduka Lime both get new HUs on transfer)
  • after cancel, an item I opted to not recombine kept its HU as expected, but stayed in the Kitchen (wasn't sure if this should go back to the original WH, in this case the Refrigerator)

@agritheory agritheory marked this pull request as draft September 20, 2023 13:57
@agritheory
Copy link
Owner Author

@HKuz Ready for review

@agritheory agritheory changed the title Draft: cancelled SLEs ignored by get_handling_unit Cancelled SLEs ignored by get_handling_unit Sep 27, 2023
@HKuz
Copy link
Collaborator

HKuz commented Sep 27, 2023

@agritheory docs look good!

@agritheory agritheory marked this pull request as ready for review September 27, 2023 22:33
@agritheory agritheory merged commit 65632de into version-14 Sep 27, 2023
6 checks passed
@agritheory agritheory deleted the ignore_cancelled_hu branch September 27, 2023 22:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore cancelled Stock Ledger Entries in get_handling_unit
3 participants