Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log_level = debug is not undrstood #210

Closed
fluca1978 opened this issue Feb 24, 2022 · 2 comments
Closed

log_level = debug is not undrstood #210

fluca1978 opened this issue Feb 24, 2022 · 2 comments
Labels
enhancement Improvement to an existing feature

Comments

@fluca1978
Copy link
Collaborator

In the configuration file, the log_level can be set to debug1 but not to debug. While this is documented, I would expect and prefer to set debug instead of debug1 that sounds more as a development setting. Also, in the case of log_level = debug the level is set to fallback info without any warning.
@fluca1978 fluca1978 added the feature New feature label Feb 24, 2022
@jesperpedersen
Copy link
Collaborator

I would say debug1.

Anything at or above info should be necessary for the user to understand the pool operation.

@jesperpedersen jesperpedersen added enhancement Improvement to an existing feature and removed feature New feature labels Feb 24, 2022
fluca1978 added a commit to fluca1978/pgagroal that referenced this issue Feb 24, 2022
@fluca1978
[agroal#210] Understand all 'debug' levels for log_level.
84db9b0 
This makes `log_level` configuration parameter understand
any "debug*" string, like "debug10", as well as "debug".
In particular, if `log_level = debug` (without any number)
the level will be set to `debug1`.
On the other hand, if `log_level = debug99` the
level will be adjusted to `debug5`.

Close agroal#210
@fluca1978
Copy link
Collaborator Author

Personally, I like the idea of log_level = debug. I've created a possible commit that allows for other debug level, even if not used at the moment.
Feel free to reject.

@fluca1978 fluca1978 mentioned this issue Feb 24, 2022
Closed
jesperpedersen pushed a commit that referenced this issue Feb 25, 2022
@fluca1978 @jesperpedersen
[#210] Understand all 'debug' levels for log_level.
b328063 
This makes `log_level` configuration parameter understand
any "debug*" string, like "debug10", as well as "debug".
In particular, if `log_level = debug` (without any number)
the level will be set to `debug1`.
On the other hand, if `log_level = debug99` the
level will be adjusted to `debug5`.

Close #210
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement to an existing feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#210] Understand all 'debug' levels for log_level. fluca1978/pgagroal
2 participants
@jesperpedersen @fluca1978