Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mistakenly reporting success on config-key for unknown global key #334

Closed
fluca1978 opened this issue Dec 13, 2022 · 0 comments
Closed

Mistakenly reporting success on config-key for unknown global key #334

fluca1978 opened this issue Dec 13, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@fluca1978
Copy link
Collaborator

Related to the implementation of #328 : if the config-get command is invoked with an invalid global key (i.e., one that belojngs to the [pgagroal] section), the system reports no error at all:

$ pgagroal-cli config-get foo_connection --verbose
pgagroal-cli: Success (0)
@fluca1978 fluca1978 added the bug Something isn't working label Dec 13, 2022
@fluca1978 fluca1978 mentioned this issue Dec 13, 2022
Closed
fluca1978 added a commit to fluca1978/pgagroal that referenced this issue Dec 13, 2022
@fluca1978
[agroal#334] Throw an error when config-get refers to a non existin…
b5516c8 
…g key

This commit fixes the problem that arise when the user specifies
a global key (i.e., one that does not exist in the section
[pgagroal]) to the subcommand `config-get`.
If the key is not known, an error is thrown.

Close agroal#334
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fluca1978