[#361] Add a max_connection_age setting
#365
Merged
+264
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Issue #361
|
jesperpedersen
requested changes
Apr 3, 2023
|
Otherwise it looks good |
hao-tian-xu
force-pushed
the
max_connection_age
branch
from
99be1d0
to
0a6e70a
Compare
|
Thanks for the feedback! I added new STATE, TRACKER, Prometheus metric, and documentation for |
hao-tian-xu
force-pushed
the
max_connection_age
branch
from
0a6e70a
to
d1b6157
Compare
jesperpedersen
requested changes
Apr 5, 2023
doc/CONFIGURATION.md
Outdated
| @@ -60,7 +60,8 @@ The available keys and their accepted values are reported in the table below. | |||
| | log_connections | `off` | Bool | No | Log connects | | |||
| | log_disconnections | `off` | Bool | No | Log disconnects | | |||
| | blocking_timeout | 30 | Int | No | The number of seconds the process will be blocking for a connection (disable = 0) | | |||
| | idle_timeout | 0 | Int | No | The number of seconds a connection is been kept alive (disable = 0) | | |||
| | idle_timeout | 0 | Int | No | The number of seconds a connection is been kept alive since becomes idle (disable = 0) | | |||
| | max_connection_age | 0 | Int | No | The number of seconds a connection is been kept alive since starts (disable = 0) | | |||
There was a problem hiding this comment.
"... since it times out"
There was a problem hiding this comment.
If I get it right,
idle_timeoutis "The number of seconds a connection can remain idle before it is automatically closed"max_connection_ageis "The number of seconds a connection can remain active before it is automatically closed if it is not being used"
There was a problem hiding this comment.
It is the maximum seconds that a connection will live - it will be checked upon returned to the pool, or during idle timeout
There was a problem hiding this comment.
Thanks for the feedback! I updated the max_connection_age docs and kept the idle_timeout docs untouched.
Checking upon returned to the pool is added to pgagroal_return_connection.
Both ways of checking are tested using a basic setup.
doc/man/pgagroal.conf.5.rst
Outdated
| The number of seconds a connection is been kept alive since becomes idle (disable = 0). Default is 0 | ||
|
|
||
| max_connection_age | ||
| The number of seconds a connection is been kept alive since starts (disable = 0). Default is 0 |
hao-tian-xu
force-pushed
the
max_connection_age
branch
from
d1b6157
to
53e9a2d
Compare
jesperpedersen
requested changes
Apr 14, 2023
src/libpgagroal/pool.c
Outdated
|
|
||
| config = (struct configuration*)shmem; | ||
|
|
||
| /* Kill the connection, if it lives longer than max_connection_age */ | ||
| now = time(NULL); |
There was a problem hiding this comment.
We need some extra checks here, right ?
Is max_connection_age > 0
There was a problem hiding this comment.
Thanks for the review! I've tested thses cases this time:
idle_timeoutoff,max_connection_ageon, one prefill, no connection / get one connection and then closeidle_timeouton,max_connection_ageoff, one prefill, get one connection and then closeidle_timeout = 20,max_connection_age = 40, one prefill, get two connections and then close
hao-tian-xu
force-pushed
the
max_connection_age
branch
from
53e9a2d
to
c13ca00
Compare
|
Can you rebase ? |
hao-tian-xu
force-pushed
the
max_connection_age
branch
from
c13ca00
to
c55b849
Compare
This defines how long a connection will live in seconds - Add a `max_connection_age` member to `struct configuration`. It will be checked upon returned to the pool, or during idle timeout. - Add new STATE, TRACKER, and Prometheus metric for `max_connection_age` - Add documentation for `max_connection_age` - Add a `start_time` member to `struct connection`. Its implementation is similar to `timestamp`
hao-tian-xu
force-pushed
the
max_connection_age
branch
from
c55b849
to
6112ec6
Compare
|
Sure, rebased and fixed conflicts |
|
Merged. Thanks for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defines how long a connection will live in seconds
max_connection_agemember tostruct configuration. Its implementation and related functions are similar toidle_timeoutstart_timemember tostruct connection. Its implementation is similar totimestamp