fix(databend sink): use get for page request (vectordotdev#17373)

aholmberg · May 18, 2023 · c7d7cf8 · c7d7cf8
1 parent ae656c7
commit c7d7cf8
Showing 1 changed file with 9 additions and 14 deletions.
diff --git a/src/sinks/databend/api.rs b/src/sinks/databend/api.rs
@@ -111,19 +111,8 @@ impl DatabendAPIClient {
 
     async fn do_request(
         &self,
-        url: String,
-        req: Option<DatabendHttpRequest>,
+        mut request: Request<Body>,
     ) -> Result<DatabendHttpResponse, DatabendError> {
-        let body = match req {
-            Some(r) => {
-                let body = serde_json::to_vec(&r)?;
-                Body::from(body)
-            }
-            None => Body::empty(),
-        };
-        let mut request = Request::post(url)
-            .header("Content-Type", "application/json")
-            .body(body)?;
         if let Some(a) = &self.auth {
             a.apply(&mut request);
         }
@@ -163,15 +152,21 @@ impl DatabendAPIClient {
         next_uri: String,
     ) -> Result<DatabendHttpResponse, DatabendError> {
         let endpoint = self.get_page_endpoint(&next_uri)?;
-        self.do_request(endpoint, None).await
+        let request = Request::get(endpoint)
+            .header("Content-Type", "application/json")
+            .body(Body::empty())?;
+        self.do_request(request).await
     }
 
     pub(super) async fn query(
         &self,
         req: DatabendHttpRequest,
     ) -> Result<DatabendHttpResponse, DatabendError> {
         let endpoint = self.get_query_endpoint()?;
-        let resp = self.do_request(endpoint, Some(req)).await?;
+        let request = Request::post(endpoint)
+            .header("Content-Type", "application/json")
+            .body(Body::from(serde_json::to_vec(&req)?))?;
+        let resp = self.do_request(request).await?;
         match resp.next_uri {
             None => Ok(resp),
             Some(_) => {