Updated CI configuration to use CircleCI 2. #75
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlexSkrypnyk
commented
Jul 17, 2019
| version: 2 | ||
| jobs: | ||
| build: | ||
| working_directory: /go/src/github.com/ahoy-cli/ahoy |
There was a problem hiding this comment.
this is where build.sh is expecting the project to be installed to
AlexSkrypnyk
commented
Jul 17, 2019
| build: | ||
| working_directory: /go/src/github.com/ahoy-cli/ahoy | ||
| docker: | ||
| - image: circleci/golang |
There was a problem hiding this comment.
standard golang image managed by circleci
AlexSkrypnyk
commented
Jul 17, 2019
| - image: circleci/golang | ||
| steps: | ||
| - checkout | ||
| - run: git clone https://github.com/bats-core/bats-core.git && cd bats-core && sudo ./install.sh /usr/local && bats --version && cd - |
There was a problem hiding this comment.
installing bats from sources. this is easier then installing it from npm, as npm installation into this image requires many more steps
AlexSkrypnyk
commented
Jul 17, 2019
| steps: | ||
| - checkout | ||
| - run: git clone https://github.com/bats-core/bats-core.git && cd bats-core && sudo ./install.sh /usr/local && bats --version && cd - | ||
| - run: sudo apt install php |
There was a problem hiding this comment.
installing php as it is required for one of the tests
AlexSkrypnyk
commented
Jul 17, 2019
| - checkout | ||
| - run: git clone https://github.com/bats-core/bats-core.git && cd bats-core && sudo ./install.sh /usr/local && bats --version && cd - | ||
| - run: sudo apt install php | ||
| - run: go get -u golang.org/x/lint/golint |
There was a problem hiding this comment.
updated golint install path
See golang/lint#415
AlexSkrypnyk
changed the title
This was referenced Jul 17, 2019
Closed
|
looks like this has been merged. closing |
hanoii
pushed a commit
to hanoii/ahoy
that referenced
this pull request
Feb 28, 2024
Updated CI configuration to use CircleCI 2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI build result in my fork (not sure why the build does not run here - maybe need to enable a flag in CI to build forks?):
https://circleci.com/gh/integratedexperts/ahoy/13