-
Notifications
You must be signed in to change notification settings - Fork 627
build: introduce dynamo base container #2222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Adding Misha's comments here for transparency:
|
We don't have caching setup for containers built via Github due to issues with the container registry. As next steps, we will look to setup some external registry which we can use to enable external caching. For now, the Dockerfile is setup to use docker's default build cache mechanism which keeps instructions which are expected to change more frequently (such as dynamo src change) towards the end of the Dockerfile instead of the beginning. |
Can we use NGC? |
@ryanolson NGC would definitely be a viable option. |
Signed-off-by: Tushar Sharma <tusharma@nvidia.com> Co-authored-by: Anant Sharma <anants@nvidia.com>
Signed-off-by: Tushar Sharma <tusharma@nvidia.com> Co-authored-by: Anant Sharma <anants@nvidia.com>
Overview:
Milestone 1 in DEP:
ai-dynamo/enhancements#8
This PR adds support for a Dynamo base container which can be used for faster prototyping and faster developer validation for PR changes. As part of the PR, we change the pre-merge check to build this Dynamo base image instead of the vLLM full fat container. As a result of this change and further optimizations to the build, we are able to reduce the time to run PR validation from 1 hour approximately to 20 minutes.
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
ref: OPS-565, OPS-607
Summary by CodeRabbit