Skip to content

Conversation

ishandhanani
Copy link
Contributor

@ishandhanani ishandhanani commented Aug 4, 2025

Overview:

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

Summary by CodeRabbit

  • Chores
    • Updated the directory path for SGLang scripts used in testing.
    • Added a note for future testing improvements related to cache flushing and expert distribution recording.

Copy link

copy-pr-bot bot commented Aug 4, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@github-actions github-actions bot added the ci Issues/PRs that reference CI build/test label Aug 4, 2025
@ishandhanani ishandhanani enabled auto-merge (squash) August 4, 2025 18:59
Copy link
Contributor

coderabbitai bot commented Aug 4, 2025

Walkthrough

The SGLang script directory path in the test suite was updated from /workspace/examples/sglang to /workspace/components/backends/sglang. Additionally, a TODO comment was added to a test function to indicate future plans for enabling and testing more HTTP endpoints. No functional changes were made to the test logic.

Changes

Cohort / File(s) Change Summary
SGLang test path update and TODO
tests/serve/test_sglang.py
Updated SGLang script base directory path in SGLangProcess instantiation and added a TODO comment for future endpoint testing in test_sglang_disagg_dp_attention.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

In the warren, paths do shift,
From examples to backends, a gentle lift.
A TODO sprouts for future care,
More endpoints soon, handled with flair.
The test suite hops, its journey slight—
A rabbit’s work, tidy and light! 🐇✨

Note

⚡️ Unit Test Generation is now available in beta!

Learn more here, or try it out under "Finishing Touches" below.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 6fed066 and e954bc3.

📒 Files selected for processing (1)
  • tests/serve/test_sglang.py (2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: nnshah1
PR: ai-dynamo/dynamo#1444
File: tests/fault_tolerance/scenarios.py:57-57
Timestamp: 2025-07-01T15:39:56.789Z
Learning: The fault tolerance tests in tests/fault_tolerance/ are designed to run only in the mounted container environment, so hardcoded absolute paths with `/workspace/` prefix are intentional and should not be changed to relative paths.
📚 Learning: the fault tolerance tests in tests/fault_tolerance/ are designed to run only in the mounted containe...
Learnt from: nnshah1
PR: ai-dynamo/dynamo#1444
File: tests/fault_tolerance/scenarios.py:57-57
Timestamp: 2025-07-01T15:39:56.789Z
Learning: The fault tolerance tests in tests/fault_tolerance/ are designed to run only in the mounted container environment, so hardcoded absolute paths with `/workspace/` prefix are intentional and should not be changed to relative paths.

Applied to files:

  • tests/serve/test_sglang.py
🪛 GitHub Actions: Pre Merge Validation of (ai-dynamo/dynamo/refs/pull/2275/merge) by ishandhanani.
tests/serve/test_sglang.py

[error] 166-166: Black formatting check failed. The file was reformatted by the black hook. Run 'black tests/serve/test_sglang.py' to fix code style issues.

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Build and Test - vllm
🔇 Additional comments (1)
tests/serve/test_sglang.py (1)

31-31: SGLang test path update is correct

The change from /workspace/examples/sglang to /workspace/components/backends/sglang matches the restructured repository layout and will resolve successfully in the container environment (where /workspace maps to the repo root). No further action required.

@pvijayakrish
Copy link
Contributor

pvijayakrish commented Aug 4, 2025

Any changes to this file tests/serve/test_sglang.py should also trigger the Gitlab validation with RUN_SGLANG=true from https://github.com/ai-dynamo/dynamo/blob/main/.github/workflows/trigger_ci.yml#L63.

@pvijayakrish pvijayakrish self-requested a review August 4, 2025 19:20
@ishandhanani ishandhanani disabled auto-merge August 4, 2025 20:14
@pull-request-size pull-request-size bot added size/S and removed size/XS labels Aug 4, 2025
@pvijayakrish
Copy link
Contributor

nit: Please make sure the changes in the components/backends/sglang/docs/multinode-examples.md files are correct.

@ishandhanani ishandhanani merged commit 8f005a6 into main Aug 4, 2025
9 checks passed
@ishandhanani ishandhanani deleted the ishan/fix-ci branch August 4, 2025 21:13
jain-ria pushed a commit that referenced this pull request Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Issues/PRs that reference CI build/test size/S
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants