-
Notifications
You must be signed in to change notification settings - Fork 627
ci: fix sglang paths for nightly #2275
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe SGLang script directory path in the test suite was updated from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
tests/serve/test_sglang.py
(2 hunks)
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: nnshah1
PR: ai-dynamo/dynamo#1444
File: tests/fault_tolerance/scenarios.py:57-57
Timestamp: 2025-07-01T15:39:56.789Z
Learning: The fault tolerance tests in tests/fault_tolerance/ are designed to run only in the mounted container environment, so hardcoded absolute paths with `/workspace/` prefix are intentional and should not be changed to relative paths.
📚 Learning: the fault tolerance tests in tests/fault_tolerance/ are designed to run only in the mounted containe...
Learnt from: nnshah1
PR: ai-dynamo/dynamo#1444
File: tests/fault_tolerance/scenarios.py:57-57
Timestamp: 2025-07-01T15:39:56.789Z
Learning: The fault tolerance tests in tests/fault_tolerance/ are designed to run only in the mounted container environment, so hardcoded absolute paths with `/workspace/` prefix are intentional and should not be changed to relative paths.
Applied to files:
tests/serve/test_sglang.py
🪛 GitHub Actions: Pre Merge Validation of (ai-dynamo/dynamo/refs/pull/2275/merge) by ishandhanani.
tests/serve/test_sglang.py
[error] 166-166: Black formatting check failed. The file was reformatted by the black hook. Run 'black tests/serve/test_sglang.py' to fix code style issues.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Build and Test - vllm
🔇 Additional comments (1)
tests/serve/test_sglang.py (1)
31-31
: SGLang test path update is correctThe change from
/workspace/examples/sglang
to/workspace/components/backends/sglang
matches the restructured repository layout and will resolve successfully in the container environment (where/workspace
maps to the repo root). No further action required.
Any changes to this file tests/serve/test_sglang.py should also trigger the Gitlab validation with RUN_SGLANG=true from https://github.com/ai-dynamo/dynamo/blob/main/.github/workflows/trigger_ci.yml#L63. |
nit: Please make sure the changes in the components/backends/sglang/docs/multinode-examples.md files are correct. |
Overview:
Details:
Where should the reviewer start?
Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)
Summary by CodeRabbit