ci: Skip gitlab job on docs-only changes, only run rust jobs on rust changes #2775
Conversation
…hanges Signed-off-by: Ryan McCormick <rmccormick@nvidia.com>
Signed-off-by: Ryan McCormick <rmccormick@nvidia.com>
WalkthroughUpdates four GitHub Actions workflows to adjust triggers: add docs-only paths-ignore filters to several workflows (push and/or pull_request) and narrow PR path filters in the Rust pre-merge workflow to only Rust-related files. No job logic changes. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
actor Dev as Developer
participant GH as GitHub
participant WF as Workflow Dispatcher
participant Jobs as Workflow Jobs
Dev->>GH: Push or Pull Request
GH->>WF: Evaluate workflow triggers
alt Docs-only changes (md/rst)
WF-->>GH: paths-ignore matched (skip)
else Non-docs changes
WF->>Jobs: Start workflow
Jobs-->>WF: Run steps
WF-->>GH: Report status
end
sequenceDiagram
autonumber
actor Dev as Developer
participant GH as GitHub
participant WF as pre-merge-rust.yml
participant Jobs as Rust Checks
Dev->>GH: Open/Update PR
GH->>WF: Check on.pull_request.paths
alt Changes include .rs/Cargo files
WF->>Jobs: Run Rust pre-merge workflow
Jobs-->>WF: Lint/Test/Build results
WF-->>GH: Status posted
else Other files or directories
WF-->>GH: No run (filtered)
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🧹 Nitpick comments (4)
.github/workflows/trigger_ci.yml (1)
23-26: Broaden docs-only ignore to cover common doc assets.Include mdx/notebooks/images and the docs/ tree to reduce unnecessary runs.
Apply:
# Skip docs only changes paths-ignore: - '**/*.md' - '**/*.rst' + - '**/*.mdx' + - '**/*.ipynb' + - 'docs/**' + - '**/*.png' + - '**/*.svg'.github/workflows/container-validation-backends.yml (1)
11-14: Consider skipping docs-only PRs too for parity with push.If desired, mirror the push ignore on pull_request. Confirm branch protection rules won’t require this workflow on docs-only PRs.
Proposed change:
on: push: branches: - main - "pull-request/[0-9]+" # Skip docs only changes paths-ignore: - '**/*.md' - '**/*.rst' + pull_request: + # Skip docs only changes + paths-ignore: + - '**/*.md' + - '**/*.rst'Optionally broaden ignores (mdx/ipynb/docs/**/images) as done in trigger_ci.
.github/workflows/pre-merge-rust.yml (1)
24-30: Include Rust build and policy files in pull_request paths
Add these underpull_request.pathsin.github/workflows/pre-merge-rust.yml:paths: - .github/workflows/pre-merge-rust.yml - '**.rs' - 'Cargo.toml' - 'Cargo.lock' + - '**/*.proto' + - 'deny.toml' + - 'rust-toolchain*' + - '.cargo/**'.github/workflows/container-validation-dynamo.yml (1)
9-13: Broaden push docs-only ignore to cut redundant builds.Align with other workflow suggestion: include mdx/notebooks/docs tree/images.
Apply:
push: branches: - main # Skip docs only changes paths-ignore: - '**/*.md' - '**/*.rst' + - '**/*.mdx' + - '**/*.ipynb' + - 'docs/**' + - '**/*.png' + - '**/*.svg'
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (4)
.github/workflows/container-validation-backends.yml(1 hunks).github/workflows/container-validation-dynamo.yml(2 hunks).github/workflows/pre-merge-rust.yml(1 hunks).github/workflows/trigger_ci.yml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (4)
- GitHub Check: Build and Test - dynamo
- GitHub Check: pre-merge-rust (lib/bindings/python)
- GitHub Check: pre-merge-rust (.)
- GitHub Check: pre-merge-rust (lib/runtime/examples)
🔇 Additional comments (2)
.github/workflows/container-validation-dynamo.yml (2)
15-18: Confirm PR docs-only skip won’t violate required-checks.If this workflow is a required check, skipping it on docs-only PRs can block merges unless branch protection treats “skipped” as passing.
Optionally expand ignores to match push:
pull_request: # Skip docs only changes paths-ignore: - '**/*.md' - '**/*.rst' + - '**/*.mdx' + - '**/*.ipynb' + - 'docs/**' + - '**/*.png' + - '**/*.svg'
100-100: LGTM (non-functional newline change).No action needed.
|
@dmitry-tokarev-nv, ⭐3 XP earned, 🏆First Code Review Done completed, 💪Level 9 achieved! [Details] |
Signed-off-by: Ryan McCormick <rmccormick@nvidia.com>
rmccorm4
force-pushed
the
rmccormick/skip_jobs_on_docs_only
branch
from
c9a6164 to
9c96120
Compare
|
@nv-anants, ⭐3 XP earned, 🏆First Code Review Done completed, 💪Level 10 achieved! [Details] |
rmccorm4
changed the title
Pull Request Summary by devActivityMetrics
Achievements
|
…changes (#2775) Signed-off-by: Ryan McCormick <rmccormick@nvidia.com> Signed-off-by: Jason Zhou <jasonzho@jasonzho-mlt.client.nvidia.com>
…changes (#2775) Signed-off-by: Ryan McCormick <rmccormick@nvidia.com> Signed-off-by: Michael Shin <michaelshin@users.noreply.github.com>
…changes (#2775) Signed-off-by: Ryan McCormick <rmccormick@nvidia.com> Signed-off-by: Krishnan Prashanth <kprashanth@nvidia.com>
…changes (#2775) Signed-off-by: Ryan McCormick <rmccormick@nvidia.com> Signed-off-by: nnshah1 <neelays@nvidia.com>
Overview:
Iterative improvement on only running certain actions when necessary
Summary by CodeRabbit