Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated expo-random package #415

Merged
merged 2 commits into from
Mar 30, 2023
Merged

Replace deprecated expo-random package #415

merged 2 commits into from
Mar 30, 2023

Conversation

silvestreh
Copy link
Contributor

Removes usage of the now deprecated expo-random. Closes #414

@ai
Copy link
Owner

ai commented Mar 9, 2023

Should we release it as Nano ID 5.0?

@silvestreh
Copy link
Contributor Author

🤔 technically speaking, expo-random has been merged into expo-crypto bringing the functionality over to the newer package. There are no breaking API changes, but then again, people using older Expo SDKs will probably be greeted with an error during build time about the expo-crypto not being found.

I believe tagging a major release, even with no new functionality, would make sense.

async/index.native.js Outdated Show resolved Hide resolved
@ai ai changed the base branch from main to v5 March 25, 2023 19:43
@ai ai merged commit 842f08f into ai:v5 Mar 30, 2023
@ai
Copy link
Owner

ai commented Mar 30, 2023

I will wait for Node.js 14 to release to make more major changes together.

@ai
Copy link
Owner

ai commented Mar 30, 2023

@silvestreh BTW, we are using expo-crypto only for async version.

Maybe we should use just browser sync version instead with polyfill (and wrap it to Promise)? Too rare use case for special version.

@ai
Copy link
Owner

ai commented Apr 1, 2023

Done 0276499

ai pushed a commit that referenced this pull request May 4, 2023
* Replace deprecated `expo-random` package

* Only import `getRandomBytesAsync`
ai pushed a commit that referenced this pull request Aug 13, 2023
* Replace deprecated `expo-random` package

* Only import `getRandomBytesAsync`
ai pushed a commit that referenced this pull request Sep 12, 2023
* Replace deprecated `expo-random` package

* Only import `getRandomBytesAsync`
@2ico 2ico mentioned this pull request Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

expo-random has been deprecated
2 participants