remove G2G arg from run_command, consolidate gpu logic in buildenv #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Performance test launched https://jenkins.ginko.ch/job/pace-fv3core-performance-test/91/. |
|
Submitted performance test again for gpu, will appear at https://jenkins.ginko.ch/job/pace-fv3core-performance-test/93/. |
|
Because the buildenv changes are backwards incompatible I will merge to main pointing to the buildenv branch, then merge the branch on buildenv, then merge a dependabot PR. |
mcgibbon
added a commit
to ai2cm/buildenv
that referenced
this pull request
Dec 17, 2021
## Infrastructure changes: - G2G is removed as an argument for run_command - DOCKER_BUILDKIT=1 is set in buildenv, not pace - PYTHONOPTIMIZE=TRUE is set in run_on_daint.sh, not in the slurm script - updated pace-util jenkins.sh to match buildenv run_command api Linked to ai2cm/pace#76
4 tasks
mcgibbon
added a commit
that referenced
this pull request
Jan 4, 2022
## Purpose A bug was introduced by #76 where an argument was removed but the argument number for the final argument (script filename) was not decremented in buildenv. This PR fixes that bug. Depends on ai2cm/buildenv#35. ## Infrastructure changes: - Fixed bug which causes scheduler script argument to be ignored in buildenv's run_command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
run_command currently takes a G2G argument we have hard-coded to always be false. This PR removes that argument, and moves several environment variables from pace into buildenv.
Depends on ai2cm/buildenv#32.
Infrastructure changes:
Checklist
Before submitting this PR, please make sure:
Additionally, if this PR contains code authored by new contributors: