Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix script argument bug in buildenv #90

Merged
merged 2 commits into from
Jan 4, 2022
Merged

fix script argument bug in buildenv #90

merged 2 commits into from
Jan 4, 2022

Conversation

mcgibbon
Copy link
Collaborator

@mcgibbon mcgibbon commented Jan 4, 2022

Purpose

A bug was introduced by #76 where an argument was removed but the argument number for the final argument (script filename) was not decremented in buildenv. This PR fixes that bug.

Depends on ai2cm/buildenv#35.

Infrastructure changes:

  • Fixed bug which causes scheduler script argument to be ignored in buildenv's run_command

Checklist

Before submitting this PR, please make sure:

  • You have followed the coding standards guidelines established at Code Review Checklist.
  • Docstrings and type hints are added to new and updated routines, as appropriate
  • All relevant documentation has been updated or added (e.g. README, CONTRIBUTING docs)
  • For each public change and fix in pace-util, HISTORY has been updated

Copy link
Contributor

@rheacangeo rheacangeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mcgibbon mcgibbon enabled auto-merge (squash) January 4, 2022 21:46
@mcgibbon mcgibbon merged commit c689a31 into main Jan 4, 2022
@mcgibbon mcgibbon deleted the fix/script_arg branch January 4, 2022 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants