Skip to content

Conversation

cmungall
Copy link
Member

@cmungall cmungall commented Aug 15, 2025

cmungall and others added 3 commits August 15, 2025 09:41
…ls on import

The METRICS dictionary was previously instantiated at module level, causing
GEval objects to be created during import. This triggered network dependencies
even when the metrics weren't being used.

Changes:
- Replace top-level METRICS dictionary with get_default_metrics() function
- Move GEval and DummyMetric instantiation into the function for lazy creation
- Update run_single_eval() to call get_default_metrics() when needed

This prevents unnecessary network calls during module import and improves
startup performance, especially in environments where network access may be
restricted or when metrics are not used in the execution path.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude <noreply@anthropic.com>
@cmungall cmungall requested a review from Copilot August 16, 2025 00:44
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR applies comprehensive code formatting using the Ruff formatter to standardize code style across the codebase. The changes include trailing comma additions, line wrapping adjustments, and consistent indentation formatting.

  • Adds ruff>=0.12.8 as a development dependency for code formatting
  • Applies consistent formatting to test files, source code, and documentation
  • Updates model names in help text to reflect more recent AI models
  • Minor comment corrections and blank line cleanup

Reviewed Changes

Copilot reviewed 21 out of 23 changed files in this pull request and generated no comments.

File Description
pyproject.toml Adds ruff as development dependency
tests/test_*.py Applies formatting with trailing commas and line wrapping
src/metacoder/*.py Standardizes code formatting and updates model examples
README.md Minor documentation updates with clearer examples

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@cmungall cmungall merged commit d47901b into main Aug 16, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant