Skip to content

Commit

Permalink
Don't raise errors in webstore.py
Browse files Browse the repository at this point in the history
  • Loading branch information
aiden2480 committed May 22, 2022
1 parent e9c41dd commit eae3da3
Show file tree
Hide file tree
Showing 4 changed files with 9 additions and 4 deletions.
6 changes: 5 additions & 1 deletion .github/workflows/webstore.py
Original file line number Diff line number Diff line change
Expand Up @@ -197,7 +197,11 @@ def github_release():
}

resp = requests.post("https://api.github.com/repos/aiden2480/kanjithing/releases", headers=headers, json=payload)
resp.raise_for_status()

# resp.raise_for_status()
if not resp.ok:
print(f"Request returned HTTP status {resp.status_code}: {resp.reason}")

lastver = thisver
print(thisver, "released")

Expand Down
2 changes: 2 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
<a href="https://chrome.google.com/webstore/detail/kanjithing/nccfelhkfpbnefflolffkclhenplhiab/reviews"><img src="https://img.shields.io/chrome-web-store/rating/nccfelhkfpbnefflolffkclhenplhiab?color=orange" title="Google chrome store rating" /></a>
<a href="https://chrome.google.com/webstore/detail/kanjithing/nccfelhkfpbnefflolffkclhenplhiab"><img src="https://img.shields.io/chrome-web-store/v/nccfelhkfpbnefflolffkclhenplhiab?color=yellow" title="Last version published on chrome web store" /></a>
<a href="https://github.com/aiden2480/kanjithing/actions/workflows/updatewebstore.yml"><img src="https://img.shields.io/github/workflow/status/aiden2480/kanjithing/Publish%20to%20chrome%20webstore?label=Publish%20workflow&color=green" title="Webstore publish workflow status" /></a>
<a href="https://github.com/aiden2480/kanjithing/blob/main/LICENCE"><img src="https://img.shields.io/github/license/aiden2480/kanjithing?color=blue" /></a>
<a href="https://aiden2480.github.io/kanjithing/"><img src="https://img.shields.io/badge/GitHub%20Pages-active-af6eeb" /></a>
</div>

## :shrug: A google chrome extension for practising kanji
Expand Down
2 changes: 1 addition & 1 deletion index.html
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ <h1>KanjiThing</h1>
<a href="https://chrome.google.com/webstore/detail/kanjithing/nccfelhkfpbnefflolffkclhenplhiab"><img src="https://img.shields.io/chrome-web-store/v/nccfelhkfpbnefflolffkclhenplhiab?color=yellow" title="Last version published on chrome web store" /></a>
<a href="https://github.com/aiden2480/kanjithing/actions/workflows/updatewebstore.yml"><img src="https://img.shields.io/github/workflow/status/aiden2480/kanjithing/Publish%20to%20chrome%20webstore?label=Publish%20workflow&color=green" title="Webstore publish workflow status" /></a>
<a href="https://github.com/aiden2480/kanjithing/blob/main/LICENCE"><img src="https://img.shields.io/github/license/aiden2480/kanjithing?color=blue" /></a>
<a href="https://aiden2480.github.io/kanjithing/"><img alt="" src="https://img.shields.io/badge/GitHub%20Pages-active-af6eeb" /></a>
<a href="https://aiden2480.github.io/kanjithing/"><img src="https://img.shields.io/badge/GitHub%20Pages-active-af6eeb" /></a>
</div>

<div id="itemdescription">
Expand Down
3 changes: 1 addition & 2 deletions js/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@
tr.appendChild(one);
tr.appendChild(two);
table.appendChild(tr);
console.log(index, element);
});
})();

Expand Down Expand Up @@ -135,7 +134,7 @@ function makeHTML(soup) {
soup = soup.replace("\n", "<br>");
} while (soup.indexOf("\n") !== -1);

console.log(soup);

return soup;
}

Expand Down

0 comments on commit eae3da3

Please sign in to comment.