Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual implementation follow up #39

Merged
merged 9 commits into from
Nov 16, 2022
Merged

Visual implementation follow up #39

merged 9 commits into from
Nov 16, 2022

Conversation

gomezzz
Copy link
Collaborator

@gomezzz gomezzz commented Nov 14, 2022

Description

Summary of changes

  • Changed API to simplify user interaction
  • Fixed problems on win / linux
  • Some minor restyling
  • Refactoring

Resolved Issues

N/A

How Has This Been Tested?

  • example jupyter notebook
  • ran tests

Related Pull Requests

johanos1 and others added 7 commits October 29, 2022 17:00
@johanos1
Update run_tests.yml
f1a9a09 
black and flake8 disagreement on white spaces before colon.
@johanos1
Merge pull request #37 from aidotse/johanos1-patch-1
d5badb2 
Update run_tests.yml
@gomezzz
WIP
ef75b2c 
- Fixed plotting on linux
- Added single plot function
- Added logging
- Formatting
@gomezzz
Bugfixing and beautification
6feb866
@gomezzz
- Some renaming, refactoring
9aec062 
- Preparing NB for finalization
@gomezzz
Removing duplicate code, flake fixes, getting rid of matplotlib warnings
ed2c532
@gomezzz
applying comments from previous review
931d088
@gomezzz gomezzz added visualization Code used to visualize the simulation example An example to showcase something feature implementing a new feature user-facing Anything that users can interact with labels Nov 14, 2022
@gomezzz gomezzz mentioned this pull request Nov 14, 2022
Merged
1 task
johanos1
johanos1 requested changes Nov 14, 2022
View reviewed changes
paseos/visualization/space_animation.py Outdated Show resolved Hide resolved
.github/workflows/run_tests.yml Show resolved Hide resolved
paseos/visualization/plot.py Show resolved Hide resolved
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@gomezzz gomezzz merged commit 538ddc7 into visual_implementation Nov 16, 2022
@gomezzz gomezzz deleted the visual-implementation-follow-up branch November 16, 2022 10:05
@gomezzz gomezzz mentioned this pull request Nov 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johanos1 johanos1 johanos1 approved these changes

Assignees
No one assigned
Labels
example An example to showcase something feature implementing a new feature user-facing Anything that users can interact with visualization Code used to visualize the simulation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gomezzz @johanos1