Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Continuous CartPole fixes and new reset procedure #59

Merged
merged 6 commits into from
Jun 14, 2022

Conversation

tsampazk
Copy link
Member

@tsampazk tsampazk commented Jun 8, 2022

  • Updated and fixed the world file for the new coordinate system
  • Updated the supervisor to use the new reset procedure

Is part of fixing the #8 issue.

@tsampazk tsampazk added bug Something isn't working refactor Refactoring existing code base labels Jun 8, 2022
@tsampazk tsampazk added this to the Release 0.2.0 milestone Jun 8, 2022
@tsampazk tsampazk requested a review from eakirtas June 8, 2022 10:30
@tsampazk tsampazk self-assigned this Jun 8, 2022
@tsampazk
Copy link
Member Author

@KelvinYang0320 could you please take a quick look at this too? It's more or less the same as the discrete case.

Copy link
Member

@KelvinYang0320 KelvinYang0320 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 😄
I have run this example for a few episodes and it looks great!

@tsampazk tsampazk merged commit b59a229 into dev Jun 14, 2022
@tsampazk tsampazk deleted the updated-continuous-cartpole branch June 14, 2022 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor Refactoring existing code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Several worlds still have old rotations Update all reset methods to use new Webots capabilities
2 participants