Skip to content
This repository was archived by the owner on Jul 10, 2021. It is now read-only.

Conversation

leconteur
Copy link

…ng n_stable argument

@leconteur
Copy link
Author

Did you check on this PR?

@alexjc
Copy link
Member

alexjc commented Nov 12, 2015

I've tested this finally, I like the change!

I think we should just save the best network within _train_layer locally and restore it immediately once that function is finished. Is there a use case for manually resetting the network? Why do we want sub-optimal weights?

@leconteur
Copy link
Author

I agree.

I only did the change in the pylearn2 backend however. I don't remember whether it is possible to implement this in the other backends. If that is not the case, maybe we should only enable it explicitly to remain coherent across the different backends.

@alexjc
Copy link
Member

alexjc commented Nov 12, 2015

There is only one functional backend right now, so if you change it for pylearn2 that's fine for this PR. Also might be a good idea to document this somewhere...

alexjc added a commit that referenced this pull request Nov 17, 2015
@alexjc
Copy link
Member

alexjc commented Nov 17, 2015

This is now implemented in 2694667. Thanks for looking into this, it helped a lot!

@alexjc alexjc closed this Nov 17, 2015
@leconteur
Copy link
Author

I was glad to have helped.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants