-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support create profile with image specified #181
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #181 +/- ##
==========================================
+ Coverage 86.54% 86.79% +0.24%
==========================================
Files 9 9
Lines 907 909 +2
==========================================
+ Hits 785 789 +4
+ Misses 122 120 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Suggestion: it would be more generally useful to support creating a profile from a yaml file configuration, similarly to |
Yes, that'll be convenient. But the feature added in this PR is for the upcoming QeApp tutorial, in the doc it can simply use new |
Hi @danielhollas, mind having a look at this one? For the config file as input, I did that for the |
Sure, will take a look tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally, LGTM! 🚀
@danielhollas thanks! |
The new test added in #181 is failing after merging to master since we changes profiles to profile.
No description provided.