Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support create profile with image specified #181

Merged
merged 2 commits into from
Jul 4, 2023
Merged

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented May 29, 2023

No description provided.

@unkcpz unkcpz added this to the v2023.1019 milestone May 29, 2023
@codecov
Copy link

codecov bot commented May 29, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.24 🎉

Comparison is base (d3c121f) 86.54% compared to head (0c01b5b) 86.79%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #181      +/-   ##
==========================================
+ Coverage   86.54%   86.79%   +0.24%     
==========================================
  Files           9        9              
  Lines         907      909       +2     
==========================================
+ Hits          785      789       +4     
+ Misses        122      120       -2     
Flag Coverage Δ
py-3.10 86.68% <100.00%> (+0.24%) ⬆️
py-3.11 86.46% <100.00%> (+0.02%) ⬆️
py-3.8 86.42% <100.00%> (+0.03%) ⬆️
py-3.9 86.53% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiidalab_launch/__main__.py 80.25% <100.00%> (+0.12%) ⬆️
aiidalab_launch/profile.py 96.84% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@danielhollas
Copy link
Contributor

Suggestion: it would be more generally useful to support creating a profile from a yaml file configuration, similarly to verdi code create

@unkcpz
Copy link
Member Author

unkcpz commented May 30, 2023

Suggestion: it would be more generally useful to support creating a profile from a yaml file configuration, similarly to verdi code create

Yes, that'll be convenient. But the feature added in this PR is for the upcoming QeApp tutorial, in the doc it can simply use new qe stack to get a QeApp-ready container. (It is exactly what you suggested at aiidalab/aiidalab-docker-stack#381 (comment)) I find it very straightforward to use that for Quantum Mobile. To keep it as simply for aiidalab-launch approach, this PR is needed.

@unkcpz
Copy link
Member Author

unkcpz commented Jul 3, 2023

Hi @danielhollas, mind having a look at this one? For the config file as input, I did that for the optimade-launch which I stole most of the code from here and had conifg file as input. I'll open a similar PR here soon.

@danielhollas
Copy link
Contributor

Sure, will take a look tomorrow.

@danielhollas danielhollas self-requested a review July 4, 2023 15:05
Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, LGTM! 🚀

@unkcpz unkcpz merged commit b6b5643 into main Jul 4, 2023
@unkcpz unkcpz deleted the fea/profile-add-image branch July 4, 2023 15:31
@unkcpz
Copy link
Member Author

unkcpz commented Jul 4, 2023

@danielhollas thanks!

@danielhollas danielhollas mentioned this pull request Jul 4, 2023
unkcpz pushed a commit that referenced this pull request Jul 5, 2023
The new test added in #181 is failing after merging to master since we changes profiles to profile.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants