Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: change profiles to profile to align with verdi #182

Merged
merged 2 commits into from
May 30, 2023

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented May 29, 2023

fixes #175

Remember to update the aiidalab doc aiidalab/aiidalab#385

tests/test_cli.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.22 🎉

Comparison is base (d3c121f) 86.54% compared to head (bff3be1) 86.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #182      +/-   ##
==========================================
+ Coverage   86.54%   86.76%   +0.22%     
==========================================
  Files           9        9              
  Lines         907      907              
==========================================
+ Hits          785      787       +2     
+ Misses        122      120       -2     
Flag Coverage Δ
py-3.10 86.65% <100.00%> (+0.22%) ⬆️
py-3.11 86.43% <100.00%> (ø)
py-3.8 86.39% <100.00%> (ø)
py-3.9 86.72% <100.00%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiidalab_launch/__main__.py 80.12% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@unkcpz unkcpz merged commit 052f354 into main May 30, 2023
@unkcpz unkcpz deleted the fix/175/profiles2profile branch May 30, 2023 20:31
@unkcpz unkcpz added this to the v2023.1019 milestone May 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nitpick: Change CLI command profiles to profile
2 participants