Trigger pull explictly if needed #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #184 +/- ##
==========================================
- Coverage 86.76% 86.29% -0.48%
==========================================
Files 9 9
Lines 907 912 +5
==========================================
Hits 787 787
- Misses 120 125 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
danielhollas
approved these changes
Jul 4, 2023
There was a problem hiding this comment.
This is a good change, thanks @unkcpz. Tested locally, works as expected. 🚀
When this is merged I'd suggest to publish a new version of aiidalab-launch, there are a bunch of updates already.
Yes, agree. |
|
@danielhollas |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #179
The
pulloption was set as the default that will cause to download latest version when it is available, which is not desired as discussed in #179. In most case, user want to keep on using the image they pulled in the first place. New version image download is better happened when explicitly triggered by settingpull.This commit first to make
--no-pullthe default of--pull/no-pulloption. The pull logic tweaks a bit that when the image does not exist, it will anyway trigger the pull. If the image exists, the--pullneed to be set to trigger the pull.