Basic cell editor #282
Merged
Basic cell editor #282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
superstar54
approved these changes
Oct 11, 2022
There was a problem hiding this comment.
LGTM!
But we should wait for the PR of aiidalab-widget-base. aiidalab/aiidalab-widgets-base#327.
|
Hi @superstar54, we should not merge this. Since the |
|
Don't worry, I think rather than revert the PR. I'll release AWB and add a new PR to bump its version here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #291
Using the
BasicCellEditorfor modifying the cell of the structure, can convert between primitive and conventional cells.This is based on the aiidalab/aiidalab-widgets-base#327.
The example is attached: