Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The api change after bump the widget base #333

Merged
merged 1 commit into from
Dec 12, 2022
Merged

The api change after bump the widget base #333

merged 1 commit into from
Dec 12, 2022

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Dec 12, 2022

I just made a test and find I forget the update when using the new aiidalab-widget-base.

danielhollas
danielhollas reviewed Dec 12, 2022
View reviewed changes
Copy link
Contributor

@danielhollas danielhollas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be good to have a test for this. :-)

@unkcpz
Copy link
Member Author

unkcpz commented Dec 12, 2022

I am wondering this too! Will try 😄
But can we get this merged first? Since I want to release a version that can be tested before we announce this to THEOS group for further tests. There is a deadline, have to do these sorts of nasty hotfixes.

@unkcpz
Copy link
Member Author

unkcpz commented Dec 12, 2022

@danielhollas thanks!

@unkcpz unkcpz merged commit a5bb3ae into master Dec 12, 2022
@unkcpz unkcpz deleted the fix/new-awb-api-change branch December 12, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielhollas danielhollas danielhollas approved these changes

@yakutovicha yakutovicha Awaiting requested review from yakutovicha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@unkcpz @danielhollas