add version when installing pseudo #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #425 +/- ##
=======================================
Coverage 52.63% 52.63%
=======================================
Files 17 17
Lines 1879 1879
=======================================
Hits 989 989
Misses 890 890
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
unkcpz
pushed a commit
that referenced
this pull request
Jun 22, 2023
There is an issue that when the aiida-pseudo update to have the latest version of library, such as from `v1,2` to `v1.3`, since in the QeApp we hardcode the library for workchain protocol, the install command in `sssp.py` will fail because it trys to install the latest version which is `v1.3` but it not compatible with the validate version that is `v1.2`. In this commit, we also hardcode the version to the install command to make sure when a new version is available in aiida-pseudo, it will still install the correct version.
This was referenced Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
QeApp failed when installing SSSP pseudo, because the new SSSP version (1.3) is released, and we hard-coded version 1.2 in QeApp, so we need to add the version when installing pseudo.