Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pseudo setter override pseudos properly #445

Merged
merged 1 commit into from
Aug 23, 2023
Merged

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Aug 22, 2023

Setting new pseudopotential is not properly work, I did some refactoring during rebase and this change is needed.

I tried to write the test for this but failed to do it, I notice @AndresOrtegaGuerrero put similar tot_charge test in submit_step_widget_generator fixture. I think the better way would be to verify the data pass to create QeWorkChainParameters dataclass.

Since I'll take over @superstar54's PR to prototype some unit tests, I'll leave this task there.

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (bd7f39b) 56.52% compared to head (41a81f4) 56.52%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #445   +/-   ##
=======================================
  Coverage   56.52%   56.52%           
=======================================
  Files          26       26           
  Lines        2321     2321           
=======================================
  Hits         1312     1312           
  Misses       1009     1009           
Flag Coverage Δ
python-3.10 56.52% <0.00%> (ø)
python-3.8 56.57% <0.00%> (ø)
python-3.9 56.57% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/aiidalab_qe/app/submission/__init__.py 70.60% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@unkcpz unkcpz merged commit 3698d85 into main Aug 23, 2023
11 checks passed
@unkcpz unkcpz deleted the pseudo-setter-bugfix branch August 23, 2023 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants