Pseudo setter override pseudos properly #445
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting new pseudopotential is not properly work, I did some refactoring during rebase and this change is needed.
I tried to write the test for this but failed to do it, I notice @AndresOrtegaGuerrero put similar tot_charge test in
submit_step_widget_generator
fixture. I think the better way would be to verify the data pass to createQeWorkChainParameters
dataclass.Since I'll take over @superstar54's PR to prototype some unit tests, I'll leave this task there.