Advanced override setting unification #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
unkcpz
commented
Sep 4, 2023
unkcpz
commented
- Remove override of sub-widgets of advanced setting
- Proper white box tests are added for widgets
- Move kpoints setting and totalchange setting into the advanced setting.
|
There is a follow-up PR required to improve the magnatization setting widget and add a unit test for it. |
unkcpz
force-pushed
the
adv-override-refac
branch
from
bd12b5c
to
29a1a37
Compare
superstar54
requested changes
Sep 5, 2023
Comment on lines
+148
to
+153
| settings = { | ||
| "kpoints_distance": self.kpoints_distance.value, | ||
| "total_charge": self.total_charge.value, | ||
| "degauss": self.smearing.degauss_value, | ||
| "smearing": self.smearing.smearing_value, | ||
| } |
There was a problem hiding this comment.
magnetization belongs to advanced settings, but its value is not used here.
| def test_kpoints_settings(): | ||
| """Test KpointSettings widget.""" | ||
| from aiidalab_qe.app.configuration.advanced import KpointSettings | ||
| def test_advanced_kpoints_settings(): |
There was a problem hiding this comment.
For the kpoints_distance and total_charge, because they are basic ipywidget, I think it doesn't need to test them separately. You already tested them when testing the advanced setting as a whole.
superstar54
approved these changes
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.