Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_profile explicitly in qe.ipynb #471

Merged
merged 1 commit into from
Sep 19, 2023
Merged

load_profile explicitly in qe.ipynb #471

merged 1 commit into from
Sep 19, 2023

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Sep 18, 2023

It is recommended to call load_profile explicitly. After aiidalab-widgets-base if not loaded a warning will throw up.

@codecov
Copy link

codecov bot commented Sep 18, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (b4b5a72) 63.65% compared to head (a70fef0) 63.65%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   63.65%   63.65%           
=======================================
  Files          40       40           
  Lines        2710     2710           
=======================================
  Hits         1725     1725           
  Misses        985      985           
Flag Coverage Δ
python-3.10 63.65% <ø> (ø)
python-3.8 63.70% <ø> (ø)
python-3.9 63.70% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@superstar54 superstar54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@unkcpz unkcpz merged commit 1c6d957 into main Sep 19, 2023
11 checks passed
@unkcpz unkcpz deleted the profile-load-explicit branch September 19, 2023 11:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants