Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove hard coded inputs #478

Merged
merged 1 commit into from
Sep 19, 2023
Merged

remove hard coded inputs #478

merged 1 commit into from
Sep 19, 2023

Conversation

superstar54
Copy link
Member

@superstar54 superstar54 commented Sep 19, 2023

The expose_inputs of the pdos and bands are not needed anymore, because these are handled in the plugin entry part.

Copy link
Member

@AndresOrtegaGuerrero AndresOrtegaGuerrero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did a test it works!, LGTM

@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.06% ⚠️

Comparison is base (ba44f52) 63.71% compared to head (d75e7f5) 63.66%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #478      +/-   ##
==========================================
- Coverage   63.71%   63.66%   -0.06%     
==========================================
  Files          40       40              
  Lines        2701     2697       -4     
==========================================
- Hits         1721     1717       -4     
  Misses        980      980              
Flag Coverage Δ
python-3.10 63.66% <ø> (-0.06%) ⬇️
python-3.8 63.71% <ø> (-0.06%) ⬇️
python-3.9 63.71% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
src/aiidalab_qe/workflows/__init__.py 53.33% <ø> (-1.22%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@superstar54 superstar54 merged commit 0c53357 into main Sep 19, 2023
11 checks passed
@superstar54 superstar54 deleted the fix_workchain branch September 19, 2023 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants