Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aiidalab-widgets-base to version 2.1.0b0 #553

Merged
merged 3 commits into from
Nov 9, 2023
Merged

Bump aiidalab-widgets-base to version 2.1.0b0 #553

merged 3 commits into from
Nov 9, 2023

Conversation

AndresOrtegaGuerrero
Copy link
Member

This PR update aiidalab-widgets-base to allow the app to visualize the supercell implementation from @superstar54

@unkcpz
Copy link
Member

unkcpz commented Nov 9, 2023

Thanks! I was about to do this 1 hour ago but was distracted by something else.

@unkcpz unkcpz changed the title updating aiidalab-widgets-base Bump aiidalab-widgets-base to version 2.1.0b0 Nov 9, 2023
Copy link
Member

@unkcpz unkcpz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait the tests and we can merge it and release another beta version of the app.

Copy link

codecov bot commented Nov 9, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (4540a86) 80.73% compared to head (8a32ecc) 80.73%.

❗ Current head 8a32ecc differs from pull request most recent head c732ad9. Consider uploading reports for the commit c732ad9 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #553   +/-   ##
=======================================
  Coverage   80.73%   80.73%           
=======================================
  Files          49       49           
  Lines        3415     3415           
=======================================
  Hits         2757     2757           
  Misses        658      658           
Flag Coverage Δ
python-3.10 80.73% <ø> (ø)
python-3.8 80.77% <ø> (ø)
python-3.9 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AndresOrtegaGuerrero
Copy link
Member Author

Let's wait the tests and we can merge it and release another beta version of the app.

Maybe lets solve the issue of the 1D and 2D bands problem and then you release it ?

@unkcpz
Copy link
Member

unkcpz commented Nov 9, 2023

Maybe lets solve the issue of the 1D and 2D bands problem and then you release it ?

Sure!

@unkcpz unkcpz merged commit 839f8d2 into main Nov 9, 2023
11 of 12 checks passed
@unkcpz unkcpz deleted the update_awb branch November 9, 2023 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants