Adding the max_wallclock_seconds setting #743
Conversation
Missing: documentation on how to do it in a plugin.
…inside a generic plugin.
for more information, see https://pre-commit.ci
|
@mikibonacci please fix the failed tests. |
|
@mikibonacci i think you are also trying to upload the export folder |
|
@mikibonacci is it possible to add a test for this option? |
|
Sure, I will add a test. |
src/aiidalab_qe/common/widgets.py
Outdated
| value=3600 * 12, | ||
| step=3600, | ||
| min=1800, | ||
| max=3600 * 24 * 10, |
There was a problem hiding this comment.
This could bring problems depending on the computer , for example piz daint has a limit of 24 hours max.
There was a problem hiding this comment.
The logic should somehow consider the restrictions of the computer (it they are present) , or there should be a help text saying the user to set the walltime depending on the restrictions of the computer you have selected
There was a problem hiding this comment.
I added a sentence, and set as max time 24h (10 days was indeed a bit too much).
Adding a sentence which tells the user to carefully set the advance code resources (included the time) `test_qeapp_computational_resources_widget` test function adapted to work with the new wallclock setting. Removed the export folder.
for more information, see https://pre-commit.ci
|
@AndresOrtegaGuerrero, I am not sure we need a test for this setting? I adapted the |
Maybe a for the builder , just to confirm that the builder is indeed generating the walltime change |
|
@AndresOrtegaGuerrero my last commit should be the one to put also the check for the builder. |
Addressing #709
I have to fix the layout, but in the meanwhile useful to see if there is some major issue.