Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Structure viewer: cell is absent when downloading structure in XYZ format. #500

Closed
yakutovicha opened this issue Aug 16, 2023 · 2 comments · Fixed by #501
Closed

Structure viewer: cell is absent when downloading structure in XYZ format. #500

yakutovicha opened this issue Aug 16, 2023 · 2 comments · Fixed by #501
Assignees
@yakutovicha
Labels
bug Something isn't working
Milestone
v2.0.2

Comments

@yakutovicha
Copy link
Member

Until recently, if one downloads XYZ structure, it always contained a cell. Now it is not the case anymore.

We should bring this functionality back and add a test for it.
@yakutovicha yakutovicha self-assigned this Aug 16, 2023
@yakutovicha yakutovicha added the bug Something isn't working label Aug 16, 2023
@yakutovicha yakutovicha added this to the v2.0.2 milestone Aug 16, 2023
@yakutovicha yakutovicha mentioned this issue Aug 16, 2023
Merged
@danielhollas
Copy link
Contributor

@yakutovicha because it was a bit of a breaking change (it changed the public traitlet) I would propose we release this in 2.1. Is that okay for you?

@yakutovicha
Copy link
Member Author

@yakutovicha because it was a bit of a breaking change (it changed the public traitlet) I would propose we release this in 2.1. Is that okay for you?

Yep!

unkcpz pushed a commit to unkcpz/aiidalab-widgets-base that referenced this issue Nov 16, 2023
@mikibonacci
Feature/kill button - adding the kill button on top of NodeTree (aiid…
c8d1283 
…alab#500)

adding the kill button to support live-killing of a workchain, just selecting it from the list and clicking on the button.

---------
Co-authored-by: Jusong Yu <jusong.yeu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@yakutovicha yakutovicha

Labels
bug Something isn't working
Projects
None yet
Milestone
v2.0.2
Development

Successfully merging a pull request may close this issue.

Structure download section: add extxyz and xsf formats aiidalab/aiidalab-widgets-base
2 participants
@danielhollas @yakutovicha