Register WorkChainNode viewer for calcfunctions and workfunctions as well #348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reusing an existing viewer for WorkChainNode that prints the output of `verdi process report` command, introduced in aiidalab#335.
danielhollas
force-pushed
the
workchain-viewer-contd
branch
from
720bf49
to
3d298d9
Compare
|
@yakutovicha one more tiny PR for you. 😊 I've modified the |
danielhollas
changed the title
yakutovicha
requested changes
Sep 7, 2022
yakutovicha
requested changes
Sep 8, 2022
yakutovicha
approved these changes
Sep 13, 2022
|
Thanks @yakutovicha! It would be great if you could cut a new release. |
done! |
unkcpz
added a commit
to unkcpz/aiidalab-widgets-base
that referenced
this pull request
Nov 16, 2023
…Workchain (aiidalab#348) fixes aiidalab#344 The register_viewer_widget decorator registers the viewer by class and the new viewer for QeAppWorkchain specifically also become the viewer of other WorkChain. It will raise the KeyError and raised which is not expected. Instead of raising the exception, nothing is returned. This is a workaround since ideally if there is no new specific viewer defined for a specific work chain, it needs to fall back to the native one of AWB. As tried in aiidalab#430
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #335 I've implemented a simple workchain viewer that prints the output of
verdi process reportcommand. I didn't realize that the same viewer will work for calcfunctions and workfunctions as well. Note that calcjobs have their own viewer that follows the output file.Before:
After:
