Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: re-strucuture the doc folder #514

Merged
merged 3 commits into from
Sep 8, 2023
Merged

DOC: re-strucuture the doc folder #514

merged 3 commits into from
Sep 8, 2023

Conversation

unkcpz
Copy link
Member

@unkcpz unkcpz commented Sep 8, 2023

No description provided.

@unkcpz unkcpz marked this pull request as draft September 8, 2023 10:46
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (7afc300) 79.31% compared to head (8efdcc8) 79.31%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #514   +/-   ##
=======================================
  Coverage   79.31%   79.31%           
=======================================
  Files          27       27           
  Lines        3834     3834           
=======================================
  Hits         3041     3041           
  Misses        793      793           
Flag Coverage Δ
python-3.10 79.31% <ø> (ø)
python-3.8 79.35% <ø> (ø)
python-3.9 79.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
aiidalab_widgets_base/bug_report.py 53.33% <ø> (ø)
aiidalab_widgets_base/computational_resources.py 69.73% <ø> (ø)

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@unkcpz unkcpz force-pushed the doc-reorg branch 8 times, most recently from d389ebf to 9340c59 Compare September 8, 2023 12:30
add logo

use pydata css

update readthedocs.yml

fix-fix

Add strict failed when warnings

bump optimade-client version

Resolve warnings in doc bulid

Solve dependencies
@unkcpz unkcpz marked this pull request as ready for review September 8, 2023 12:35
@unkcpz
Copy link
Member Author

unkcpz commented Sep 8, 2023

@@ -46,7 +41,7 @@

# General information about the project.
project = "aiidalab-widgets-base"
copyright_first_year = "2020"
copyright_first_year = "2023"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't it be the year the documentation was created?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are correct, it didn't notice "first_year" 😆

Copy link
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor question, otherwise good 👍

docs/source/conf.py Outdated Show resolved Hide resolved
Copy link
Member

@yakutovicha yakutovicha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually need those changes very much, because I run into the same issues that you fixed here. So let's merge it 😎

Thanks, @unkcpz!

@yakutovicha yakutovicha merged commit 2c29a9e into master Sep 8, 2023
13 checks passed
@yakutovicha yakutovicha deleted the doc-reorg branch September 8, 2023 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants