Drop support for py38 #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #557 +/- ##
==========================================
- Coverage 87.07% 87.07% -0.01%
==========================================
Files 27 27
Lines 4650 4649 -1
==========================================
- Hits 4049 4048 -1
Misses 601 601
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
danielhollas
requested changes
Feb 21, 2024
There was a problem hiding this comment.
More importantly, the current Docker stack based on Jupyter docker image is currently Python 3.9, and it was never actually 3.8, so this is a safe deprecation. It would only affect people that are still on the old old docker stack, and those should really just migrate to the new one.
Thanks @unkcpz !
[pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci
unkcpz
force-pushed
the
drop-support-py38
branch
from
d867ac6
to
24b5e05
Compare
danielhollas
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The support for Python versions follows the same timeline as that of numpy, defined in NEP 029. According to that schema, Python 3.8 is no longer support as of April 14 2023 and so official support is also dropped in AWB.