-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generalize workchain sphinx extension to processes #3314
Conversation
first working build of docs
Closing for further updates & harmonization with #3299 |
+ apply linter
+ fix XML reference
Co-Authored-By: Sebastiaan Huber <mail@sphuber.net>
it seems on travis you get 'basestring' instead of 'str'
0d2af6c
to
b5150f8
Compare
@sphuber ready for review now :-) |
Thanks a lot @ltalirz |
Hm... while the docs build on travis seems to work fine, it seems this broke the docs build on readthedocs. Espen mentioned something like this as well but I may have misunderstood him before. |
Hi @italirz, as I mentioned, just a typo at line 468 of your new version (dimnensional) in the page. For the Also, I'd clearly state always when the value to be supplied is not a string (Boolean or AiiDA object) |
For that we should use the |
Fixes #3016
This PR
CalcJob
interfaceI.e. you can now do:
Currently, the implementation of the
aiida-workchain
andaiida-calcjob
directives are identical toaiida-process
(simply inherit from the class) but they can easily be customized in the future.This PR includes some modifications introduced by #3299