Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes #1125 due to missing aync override #1126

Merged
merged 5 commits into from
Jul 18, 2024

Conversation

thehesiod
Copy link
Collaborator

No description provided.

@thehesiod thehesiod linked an issue Jul 18, 2024 that may be closed by this pull request
6 tasks
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 14 lines in your changes missing coverage. Please review.

Project coverage is 86.14%. Comparing base (eae9743) to head (23ef769).
Report is 128 commits behind head on master.

Files with missing lines Patch % Lines
aiobotocore/httpchecksum.py 30.00% 14 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1126      +/-   ##
==========================================
- Coverage   86.33%   86.14%   -0.19%     
==========================================
  Files          62       62              
  Lines        5913     5933      +20     
==========================================
+ Hits         5105     5111       +6     
- Misses        808      822      +14     
Flag Coverage Δ
unittests 86.14% <33.33%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thehesiod
Copy link
Collaborator Author

i added a test but it doesn't seem like moto completely supports it, I tried updating moto but I need to re-architect how the moto service works because apparently now you only need one (yay)

@thehesiod
Copy link
Collaborator Author

did the re-architect, and a ton of tests break due to incompatibilities between botocore/moto

Copy link
Collaborator

@jakob-keller jakob-keller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakob-keller jakob-keller added the bug Something isn't working label Jul 18, 2024
@thehesiod
Copy link
Collaborator Author

put the changes in a branch, we can re-visit it later

@thehesiod thehesiod merged commit 7154abc into master Jul 18, 2024
12 of 13 checks passed
@thehesiod thehesiod deleted the thehesiod/aio-checksum-streaming branch July 18, 2024 15:11
chemelli74 pushed a commit to chemelli74/aiobotocore that referenced this pull request Aug 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

s3.get_object(ChecksumMode='ENABLED') causes an exception
2 participants