Fix broken Cookies support

[asvetlov]

Broken on Python 3.4 by #1453

https://travis-ci.org/aio-libs/aiohttp-session/jobs/184720151
https://travis-ci.org/aio-libs/aiohttp-security/jobs/184720027

[thehesiod]

looking

[thehesiod]

works for me on OSX:

amohr@amohr-macbook:~/dev/third_party/aiohttp-session$ python3.4 `which py.test` ./tests/
============================================================================================================================= test session starts ==============================================================================================================================
platform darwin -- Python 3.4.3, pytest-3.0.6, py-1.4.32, pluggy-0.4.0
rootdir: /Users/amohr/dev/third_party/aiohttp-session, inifile: 
plugins: cov-2.4.0, aiohttp-0.1.2
collected 36 items 

tests/test_abstract_storage.py .
tests/test_cookie_storage.py .....
tests/test_encrypted_cookie_storage.py .....
tests/test_get_session.py ..
tests/test_http_exception.py .
tests/test_nacl_storage.py .....
tests/test_redis_storage.py ........
tests/test_session_dict.py .........

========================================================================================================================== 36 passed in 0.67 seconds ===========================================================================================================================

amohr@amohr-macbook:~/dev/third_party/aiohttp-session$ cat aiohttp_session/__init__.py 
"""User sessions for aiohttp.web."""

import abc
import asyncio
from collections import MutableMapping
import json
import time

from aiohttp import web


__version__ = '0.8.0'


amohr@amohr-macbook:~/dev/third_party/aiohttp-session$ python3.4 -m pip list | grep aio
aiobotocore (0.1.1, /Users/amohr/dev/third_party/aiobotocore)
aiohttp (1.2.0)
aiohttp-session (0.8.0, /Users/amohr/dev/third_party/aiohttp-session)
aiopg (0.7.0)
aioredis (0.2.9)
pytest-aiohttp (0.1.2)

[fafhrd91]

maybe depends on python version? travis fails with python3.4.2 but you use 3.4.3

[thehesiod]

can someone add 3.4.3 to travis? if it passes then I'm assuming it's a bug in 3.4.2

[jettify]

created PR to check 3.4.3 https://travis-ci.org/aio-libs/aiohttp-security/jobs/194945494

[jettify]

And tests are green!

[fafhrd91]

perfect!

[thehesiod]

yay, @jettify @asvetlov is there a way to disallow 3.4.2 in setup.py?

[thehesiod]

I think I found the fix btw: http://bugs.python.org/issue22775, found from https://docs.python.org/3.4/whatsnew/changelog.html#python-3-4-3

[jettify]

Is any way to use http://bugs.python.org/review/22775/diff/13196/Lib/http/cookies.py to workaround this bug for 3.4.2 ? or should we care about 3.4.2 ?

[fafhrd91]

i'd say we do not care about 3.4.2, it is too old.

@asvetlov ?

[jettify]

cc @popravich @kxepal

[fafhrd91]

anyone?

[fafhrd91]

closing. if anyone wants to talk about python3.4.2 support, please re-open.

[kxepal]

Late for the party. Support of 3.4.2 and 3.4 at all sounds without any reasons to do for me, but if people would like to contribute compatibility fixes without breaking or making support of modern Pythons complicated - that's fine.

[fafhrd91]

added back port for python3.4.2

[lock]

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.