Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issues about #1025 and #1044 #1088

Merged
merged 8 commits into from
Aug 25, 2016
Merged

Issues about #1025 and #1044 #1088

merged 8 commits into from
Aug 25, 2016

Conversation

Taekyoon
Copy link
Contributor

@Taekyoon Taekyoon commented Aug 15, 2016 •
edited by asvetlov
Loading

What do these changes do?

#1025 add two parameters to ws_connect : proxy, proxy_auth
#1044 added a function make_netloc because of the host data size problem.

Are there changes in behavior for the user?

Related issue number

#1025
#1044

Checklist

  • [ V ] I think the code is well written
  • [ V ] Unit tests for the changes exist
  • Documentation reflects the changes

@Taekyoon
Implement proxy support for ClientSession.ws_connect
a52c4ea 
aio-libs#1025 Maybe.. Done..
I didn't check by Test mock....
But you said this would beeee OK... Hopefully ^^

This is my first commit.
@Taekyoon
Client can not handle hostnames with 63 bytes when a port is given in…
f3738f2 
… the url aio-libs#1044

I handled by reconstructing url string.
And I used function make_netlog in client_reqrep.py
@Taekyoon
Merge branch 'master' of https://github.com/KeepSafe/aiohttp
af929b2
@Taekyoon
Client can not handle hostnames with 63 bytes when a port is given in…
ec6802b 
… the url aio-libs#1044

I handled by reconstructing url string.
And I used function make_netlog in client_reqrep.py
@asvetlov
Copy link
Member

I'm sorry but I remember you have some tests.
Did you forget to include them?

@Taekyoon
Copy link
Contributor Author

I'll check right now

나의 iPhone에서 보냄

      1. 오후 10:54 Andrew Svetlov notifications@github.com 작성:

I'm sorry but I remember you have some tests.
Did you forget to include them?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@Taekyoon
Copy link
Contributor Author

I'm sorry Andrew..

Test method is missing.
but I can make this again.
I'll pull request right again.

2016-08-15 23:23 GMT+09:00 Choi Taekyoon tgchoi03@gmail.com:

I'll check right now

나의 iPhone에서 보냄

      1. 오후 10:54 Andrew Svetlov notifications@github.com 작성:

I'm sorry but I remember you have some tests.
Did you forget to include them?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1088 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/APzxmTUnwCcjn2PvlN8ZskLwuJpX_yLYks5qgG-OgaJpZM4JkZQi
.

@Taekyoon
Client can not handle hostnames with 63 bytes when a port is given in…
2e6bb64 
… the url aio-libs#1044

#last Message##############################
I handled by reconstructing url string.
And I used function make_netlog in client_reqrep.py
#########################################

I added missing test functions.
It would verify by these methods
@Taekyoon
Client can not handle hostnames with 63 bytes when a port is given in…
b2c9076 
… the url aio-libs#1044

#last Message##############################
I handled by reconstructing url string.
And I used function make_netlog in client_reqrep.py
#########################################

I added missing test functions.
It would verify by these methods
@Taekyoon Taekyoon closed this Aug 15, 2016
@Taekyoon Taekyoon reopened this Aug 15, 2016
@Taekyoon
Copy link
Contributor Author

I Added 3 test functions about #1044.

@Taekyoon
Fix the code format.
082b874 
They all checked by flake8
@Taekyoon
Copy link
Contributor Author

I checked some problem from flake.
And I fixed it.

@Taekyoon Taekyoon closed this Aug 16, 2016
@Taekyoon Taekyoon reopened this Aug 16, 2016
@Taekyoon
Fix the code format. @ client_reqrep.py
13ca7fe 
They all checked by flake8
@asvetlov asvetlov merged commit 1a64fa7 into aio-libs:master Aug 25, 2016
@asvetlov asvetlov mentioned this pull request Aug 25, 2016
Closed
@asvetlov
Copy link
Member

Thanks!

@asvetlov asvetlov mentioned this pull request Aug 25, 2016
Closed
@Taekyoon
Copy link
Contributor Author

Me either!!
I really thank you because you taught me how to commit the project.
This experience would be useful to my future activity.
Thank you so much!

@machikoyasuda machikoyasuda mentioned this pull request Oct 6, 2016
Closed
@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Taekyoon @asvetlov