-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues about #1025 and #1044 #1088
Conversation
aio-libs#1025 Maybe.. Done.. I didn't check by Test mock.... But you said this would beeee OK... Hopefully ^^ This is my first commit.
… the url aio-libs#1044 I handled by reconstructing url string. And I used function make_netlog in client_reqrep.py
… the url aio-libs#1044 I handled by reconstructing url string. And I used function make_netlog in client_reqrep.py
I'm sorry but I remember you have some tests. |
I'll check right now 나의 iPhone에서 보냄
|
I'm sorry Andrew.. Test method is missing. 2016-08-15 23:23 GMT+09:00 Choi Taekyoon tgchoi03@gmail.com:
|
… the url aio-libs#1044 #last Message############################## I handled by reconstructing url string. And I used function make_netlog in client_reqrep.py ######################################### I added missing test functions. It would verify by these methods
… the url aio-libs#1044 #last Message############################## I handled by reconstructing url string. And I used function make_netlog in client_reqrep.py ######################################### I added missing test functions. It would verify by these methods
I Added 3 test functions about #1044. |
They all checked by flake8
I checked some problem from flake. |
They all checked by flake8
Thanks! |
Me either!! |
What do these changes do?
#1025 add two parameters to ws_connect : proxy, proxy_auth
#1044 added a function make_netloc because of the host data size problem.
Are there changes in behavior for the user?
Related issue number
#1025
#1044
Checklist