Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tone down the logging level of the home dir not found warning #3351

Merged
merged 2 commits into from
Oct 20, 2018

Conversation

agronholm
Copy link
Contributor

@agronholm agronholm commented Oct 20, 2018

It is common for the home directory to be unresolvable in Docker containers.

What do these changes do?

It reduces noise when the home directory cannot be resolved when looking for the .netrc file.

Are there changes in behavior for the user?

None whatsoever.

Related issue number

This change was discussed in #3267.

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

It is common for the home directory to be unresolvable in Docker containers.
@codecov-io
Copy link

codecov-io commented Oct 20, 2018

Codecov Report

Merging #3351 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3351   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files          44       44           
  Lines        8337     8337           
  Branches     1369     1369           
=======================================
  Hits         8168     8168           
  Misses         71       71           
  Partials       98       98
Impacted Files Coverage Δ
aiohttp/helpers.py 97.12% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f46766d...203e928. Read the comment docs.

@asvetlov asvetlov merged commit fd7bb7c into aio-libs:master Oct 20, 2018
@asvetlov
Copy link
Member

Thanks!

@lock
Copy link

lock bot commented Oct 28, 2019

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a [new issue] for related bugs.
If you feel like there's important points made in this discussion, please include those exceprts into that [new issue].
[new issue]: https://github.com/aio-libs/aiohttp/issues/new

@lock lock bot added the outdated label Oct 28, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 28, 2019
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bot:chronographer:provided There is a change note present in this PR outdated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants