-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update contributing guide so new contributors can successfully install dependencies #4161
Conversation
Codecov Report
@@ Coverage Diff @@
## master #4161 +/- ##
=======================================
Coverage 97.63% 97.63%
=======================================
Files 43 43
Lines 8825 8825
Branches 1381 1381
=======================================
Hits 8616 8616
Misses 88 88
Partials 121 121 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This can work but I prefer a couple commands here:
make cythonize
pip install -r requirements/dev.txt
Another option can be adding |
@asvetlov ok I'll fix that. how about something like |
Sounds good |
Thanks! |
What do these changes do?
Update contributing guide so new contributors can successfully install dependencies
Are there changes in behavior for the user?
no
Related issue number
Fixes #4160
Checklist
CONTRIBUTORS.txt
CHANGES
folder<issue_id>.<type>
for example (588.bugfix)issue_id
change it to the pr id after creating the pr.feature
: Signifying a new feature..bugfix
: Signifying a bug fix..doc
: Signifying a documentation improvement..removal
: Signifying a deprecation or removal of public API..misc
: A ticket has been closed, but it is not of interest to users.