Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue4810 #4824

Closed
wants to merge 3 commits into from
Closed

Issue4810 #4824

wants to merge 3 commits into from

Conversation

guusbertens
Copy link
Contributor

Small updates to contributions guide:

  • Urge contributors to use latest version of the guide
  • Fix test coverage reporting command
  • Small grammer fix

Related issue: #4810

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 12, 2020
@guusbertens
Copy link
Contributor Author

It would be good to have commit 242dc8d backported, so it ends up in the online documentation.

Apologies, I messed up the commit message of that commit.

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2020

Codecov Report

Merging #4824 into master will decrease coverage by 0.40%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4824      +/-   ##
==========================================
- Coverage   97.60%   97.20%   -0.41%     
==========================================
  Files          43       43              
  Lines        8932     8932              
  Branches     1406     1406              
==========================================
- Hits         8718     8682      -36     
- Misses         95      126      +31     
- Partials      119      124       +5     
Impacted Files Coverage Δ
aiohttp/web_runner.py 92.47% <0.00%> (-5.31%) ⬇️
aiohttp/pytest_plugin.py 92.54% <0.00%> (-4.97%) ⬇️
aiohttp/tcp_helpers.py 90.00% <0.00%> (-3.34%) ⬇️
aiohttp/connector.py 94.34% <0.00%> (-1.94%) ⬇️
aiohttp/test_utils.py 99.06% <0.00%> (-0.63%) ⬇️
aiohttp/web_protocol.py 92.39% <0.00%> (-0.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 385b03e...94e3c03. Read the comment docs.

@guusbertens
Copy link
Contributor Author

Wow, I messed up this PR. Multiple issues in one PR, one of which could be backported, and a non-descriptive title. Time to redo it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants