Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small updates to contributors guide #4825

Merged
merged 4 commits into from
Oct 15, 2020
Merged

Small updates to contributors guide #4825

merged 4 commits into from
Oct 15, 2020

Conversation

guusbertens
Copy link
Contributor

Summary

Small updates to the contributors guide:

  • Refer contributors to latest version of the guide
  • Grammer fix
  • Fix command for test coverage report

Related issue: #4810

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES folder
    • name it <issue_id>.<type> for example (588.bugfix)
    • if you don't have an issue_id change it to the pr id after creating the pr
    • ensure type is one of the following:
      • .feature: Signifying a new feature.
      • .bugfix: Signifying a bug fix.
      • .doc: Signifying a documentation improvement.
      • .removal: Signifying a deprecation or removal of public API.
      • .misc: A ticket has been closed, but it is not of interest to users.
    • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."

@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Jun 12, 2020
@guusbertens
Copy link
Contributor Author

It would be good to backport commit 9b0f858, so that this is updated on docs.aiohttp.org soon. Could any of you take this up? If not, how should I go about?

@codecov-commenter
Copy link

codecov-commenter commented Jun 12, 2020

Codecov Report

Merging #4825 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4825   +/-   ##
=======================================
  Coverage   97.60%   97.60%           
=======================================
  Files          43       43           
  Lines        8932     8932           
  Branches     1406     1406           
=======================================
  Hits         8718     8718           
  Misses         95       95           
  Partials      119      119           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 385b03e...632dd7e. Read the comment docs.

@asvetlov asvetlov merged commit f079e36 into aio-libs:master Oct 15, 2020
@asvetlov
Copy link
Member

Thanks!

patchback bot pushed a commit that referenced this pull request Oct 15, 2020
* docs/contributing: refer to latest version of contrib guide

* docs/contributing: grammer fix

* docs/contributing: fix command for test coverage report

* added CHANGES file

(cherry picked from commit f079e36)
asvetlov pushed a commit that referenced this pull request Oct 15, 2020
* docs/contributing: refer to latest version of contrib guide

* docs/contributing: grammer fix

* docs/contributing: fix command for test coverage report

* added CHANGES file

(cherry picked from commit f079e36)

Co-authored-by: Guus Bertens <33204992+guusbertens@users.noreply.github.com>
asvetlov pushed a commit that referenced this pull request Oct 16, 2020
* docs/contributing: refer to latest version of contrib guide

* docs/contributing: grammer fix

* docs/contributing: fix command for test coverage report

* added CHANGES file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants