[PR #4795/9bdee369 backport][3.7] Fix resolver task is not awaited when connector is cancelled #5050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![patchback[bot]](https://avatars.githubusercontent.com/in/21488?s=60&v=4){kind=small}
* Add test to reproduce the issue "Task exception was never retrieved" on connector cancellation and dns resolver returns error * Fix connector launching resolver task is not awaited in case of CancelledError * Add myself to contributors * Add file to CHANGES Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com> (cherry picked from commit 9bdee36)
psf-chronographer
bot
added
the
bot:chronographer:provided
Codecov Report
@@ Coverage Diff @@
## 3.7 #5050 +/- ##
=======================================
Coverage 97.72% 97.72%
=======================================
Files 44 44
Lines 8965 8972 +7
Branches 1410 1411 +1
=======================================
+ Hits 8761 8768 +7
Misses 88 88
Partials 116 116
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
asvetlov
deleted the
patchback/backports/3.7/9bdee3695172ff048b298480044600a5c1c72150/pr-4795
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a backport of PR #4795 as merged into master (9bdee36).
Fixes #4330
Are there changes in behavior for the user?
No
Related issue number
#4330
Checklist
CONTRIBUTORS.txtCHANGESfolder<issue_id>.<type>for example (588.bugfix)issue_idchange it to the pr id after creating the pr.feature: Signifying a new feature..bugfix: Signifying a bug fix..doc: Signifying a documentation improvement..removal: Signifying a deprecation or removal of public API..misc: A ticket has been closed, but it is not of interest to users.