Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR #7684/30850ba backport][3.9] Fix #7306 - Set ClientWebSocketResponse.close_code correctly in concu… #7690

Conversation

ttsia
Copy link
Contributor

@ttsia ttsia commented Oct 10, 2023

This is a backport of PR #7680 as merged into master (30850ba).

Fixes the issue when If one asyncio task is waiting on receiving data and another asyncio task is closing the connection. The ClientWebSocketResponse.close_code will be None after connection closed.

…in concurrent closing scenario (aio-libs#7680)

(cherry picked from commit 30850ba)
@ttsia ttsia requested a review from asvetlov as a code owner October 10, 2023 06:19
@psf-chronographer psf-chronographer bot added the bot:chronographer:provided There is a change note present in this PR label Oct 10, 2023
@Dreamsorcerer Dreamsorcerer merged commit dde1446 into aio-libs:3.9 Oct 11, 2023
25 of 30 checks passed
xiangxli pushed a commit to xiangxli/aiohttp that referenced this pull request Dec 4, 2023
…ntWebSocketResponse.close_code correctly in concu… (aio-libs#7690)

This is a backport of PR aio-libs#7680
as merged into master
(aio-libs@30850ba).

Fixes the issue when If one asyncio task is waiting on receiving data
and another asyncio task is closing the connection. The
ClientWebSocketResponse.close_code will be None after connection closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot:chronographer:provided There is a change note present in this PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants