-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade the deprecated GitHub Actions set-output
workflow command syntax
#8339
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8339 +/- ##
=======================================
Coverage 97.55% 97.55%
=======================================
Files 107 107
Lines 33069 33069
Branches 3882 3882
=======================================
Hits 32260 32260
Misses 589 589
Partials 220 220
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change is correct but I've stated a few style preferences FTR.
set-output
workflow command syntax
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
Please, re-run failed jobs - there's trouble with coverage upload (it needs some retries). |
Backport to 3.9: 💚 backport PR created✅ Backport PR branch: Backported as #8348 🤖 @patchback |
…yntax Updating the way of saving output for cache path, cause [GitHub Actions deprecating save-state and set-output commands](https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/) PR #8339 Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com> (cherry picked from commit c26f356)
Backport to 3.10: 💚 backport PR created✅ Backport PR branch: Backported as #8349 🤖 @patchback |
…yntax Updating the way of saving output for cache path, cause [GitHub Actions deprecating save-state and set-output commands](https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/) PR #8339 Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com> (cherry picked from commit c26f356)
…ns `set-output` workflow command syntax (#8348) **This is a backport of PR #8339 as merged into master (c26f356).** Updating the way of saving output for cache path, cause [GitHub Actions deprecating save-state and set-output commands](https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/)
…ons `set-output` workflow command syntax (#8349) **This is a backport of PR #8339 as merged into master (c26f356).** Updating the way of saving output for cache path, cause [GitHub Actions deprecating save-state and set-output commands](https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/)
What do these changes do?
Updating the way of saving output for cache path, cause
GitHub Actions deprecating save-state and set-output commands
Are there changes in behavior for the user?
No
Is it a substantial burden for the maintainers to support this?
Related issue number
No
Checklist
CONTRIBUTORS.txt
CHANGES/
foldername it
<issue_or_pr_num>.<type>.rst
(e.g.588.bugfix.rst
)if you don't have an issue number, change it to the pull request
number after creating the PR
.bugfix
: A bug fix for something the maintainers deemed animproper undesired behavior that got corrected to match
pre-agreed expectations.
.feature
: A new behavior, public APIs. That sort of stuff..deprecation
: A declaration of future API removals and breakingchanges in behavior.
.breaking
: When something public is removed in a breaking way.Could be deprecated in an earlier release.
.doc
: Notable updates to the documentation structure or buildprocess.
.packaging
: Notes for downstreams about unobvious side effectsand tooling. Changes in the test invocation considerations and
runtime assumptions.
.contrib
: Stuff that affects the contributor experience. e.g.Running tests, building the docs, setting up the development
environment.
.misc
: Changes that are hard to assign to any of the abovecategories.
Make sure to use full sentences with correct case and punctuation,
for example:
Use the past tense or the present tense a non-imperative mood,
referring to what's changed compared to the last released version
of this project.