Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade the deprecated GitHub Actions set-output workflow command syntax #8339

Merged
merged 5 commits into from
Apr 18, 2024

Conversation

Olegt0rr
Copy link
Contributor

@Olegt0rr Olegt0rr commented Apr 15, 2024

What do these changes do?

Updating the way of saving output for cache path, cause
GitHub Actions deprecating save-state and set-output commands

Are there changes in behavior for the user?

No

Is it a substantial burden for the maintainers to support this?

Related issue number

No

Checklist

  • I think the code is well written
  • Unit tests for the changes exist
  • Documentation reflects the changes
  • If you provide code modification, please add yourself to CONTRIBUTORS.txt
    • The format is <Name> <Surname>.
    • Please keep alphabetical order, the file is sorted by names.
  • Add a new news fragment into the CHANGES/ folder
    • name it <issue_or_pr_num>.<type>.rst (e.g. 588.bugfix.rst)

    • if you don't have an issue number, change it to the pull request
      number after creating the PR

      • .bugfix: A bug fix for something the maintainers deemed an
        improper undesired behavior that got corrected to match
        pre-agreed expectations.
      • .feature: A new behavior, public APIs. That sort of stuff.
      • .deprecation: A declaration of future API removals and breaking
        changes in behavior.
      • .breaking: When something public is removed in a breaking way.
        Could be deprecated in an earlier release.
      • .doc: Notable updates to the documentation structure or build
        process.
      • .packaging: Notes for downstreams about unobvious side effects
        and tooling. Changes in the test invocation considerations and
        runtime assumptions.
      • .contrib: Stuff that affects the contributor experience. e.g.
        Running tests, building the docs, setting up the development
        environment.
      • .misc: Changes that are hard to assign to any of the above
        categories.
    • Make sure to use full sentences with correct case and punctuation,
      for example:

      Fixed issue with non-ascii contents in doctest text files
      -- by :user:`contributor-gh-handle`.

      Use the past tense or the present tense a non-imperative mood,
      referring to what's changed compared to the last released version
      of this project.

@Olegt0rr Olegt0rr requested a review from webknjaz as a code owner April 15, 2024 23:57
@Olegt0rr

This comment has been minimized.

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.55%. Comparing base (5a6949d) to head (25c58d1).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8339   +/-   ##
=======================================
  Coverage   97.55%   97.55%           
=======================================
  Files         107      107           
  Lines       33069    33069           
  Branches     3882     3882           
=======================================
  Hits        32260    32260           
  Misses        589      589           
  Partials      220      220           
Flag Coverage Δ
CI-GHA 97.46% <ø> (ø)
OS-Linux 97.13% <ø> (ø)
OS-Windows 95.57% <ø> (ø)
OS-macOS 96.73% <ø> (-0.07%) ⬇️
Py-3.10.11 95.42% <ø> (ø)
Py-3.10.14 96.93% <ø> (-0.01%) ⬇️
Py-3.11.9 97.12% <ø> (ø)
Py-3.12.2 96.94% <ø> (ø)
Py-3.12.3 95.42% <ø> (ø)
Py-3.8.10 95.35% <ø> (ø)
Py-3.8.18 96.78% <ø> (ø)
Py-3.9.13 95.39% <ø> (ø)
Py-3.9.19 96.88% <ø> (-0.04%) ⬇️
Py-pypy7.3.15 96.44% <ø> (-0.01%) ⬇️
VM-macos 96.73% <ø> (-0.07%) ⬇️
VM-ubuntu 97.13% <ø> (ø)
VM-windows 95.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dreamsorcerer
Copy link
Member

I'll leave this for @webknjaz to evaluate. I also have #7442 related to this.

Copy link
Member

@webknjaz webknjaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change is correct but I've stated a few style preferences FTR.

.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
.github/workflows/ci-cd.yml Outdated Show resolved Hide resolved
@webknjaz webknjaz added backport-3.9 backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note labels Apr 16, 2024
@webknjaz webknjaz changed the title GitHub Actions: Deprecating save-state and set-output commands Upgrade the deprecated GitHub Actions set-output workflow command syntax Apr 16, 2024
Olegt0rr and others added 2 commits April 16, 2024 18:42
Co-authored-by: Sviatoslav Sydorenko (Святослав Сидоренко) <wk.cvs.github@sydorenko.org.ua>
@Olegt0rr
Copy link
Contributor Author

Please, re-run failed jobs - there's trouble with coverage upload (it needs some retries).

@webknjaz webknjaz merged commit c26f356 into aio-libs:master Apr 18, 2024
36 of 37 checks passed
Copy link
Contributor

patchback bot commented Apr 18, 2024

Backport to 3.9: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.9/c26f356234c3b49e08f9cab3019b88f5d42f1aa8/pr-8339

Backported as #8348

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 18, 2024
…yntax

Updating the way of saving output for cache path, cause
[GitHub Actions deprecating save-state and set-output
commands](https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/)

PR #8339

Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com>
(cherry picked from commit c26f356)
Copy link
Contributor

patchback bot commented Apr 18, 2024

Backport to 3.10: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.10/c26f356234c3b49e08f9cab3019b88f5d42f1aa8/pr-8339

Backported as #8349

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

patchback bot pushed a commit that referenced this pull request Apr 18, 2024
…yntax

Updating the way of saving output for cache path, cause
[GitHub Actions deprecating save-state and set-output
commands](https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/)

PR #8339

Co-authored-by: Sviatoslav Sydorenko <sviat@redhat.com>
(cherry picked from commit c26f356)
webknjaz pushed a commit that referenced this pull request Apr 19, 2024
…ns `set-output` workflow command syntax (#8348)

**This is a backport of PR #8339 as merged into master
(c26f356).**

Updating the way of saving output for cache path, cause
[GitHub Actions deprecating save-state and set-output
commands](https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/)
webknjaz pushed a commit that referenced this pull request Apr 19, 2024
…ons `set-output` workflow command syntax (#8349)

**This is a backport of PR #8339 as merged into master
(c26f356).**

Updating the way of saving output for cache path, cause
[GitHub Actions deprecating save-state and set-output
commands](https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/)
@Olegt0rr Olegt0rr deleted the actions-cache-update branch April 19, 2024 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-3.10 Trigger automatic backporting to the 3.10 release branch by Patchback robot bot:chronographer:skip This PR does not need to include a change note
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants