Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Java Api pack into the release pack #520

Merged
merged 2 commits into from
Jun 13, 2018
Merged

Java Api pack into the release pack #520

merged 2 commits into from
Jun 13, 2018

Conversation

AionJayT
Copy link
Collaborator

@AionJayT AionJayT commented Jun 8, 2018

Notice

It is not allowed to submit your PR to the master branch directly, please submit your PR to the master-pre-merge branch.

Description

Please include a brief summary of the change that this pull request proposes. Include any relevant motivation and context. List any dependencies required for this change.

  • Pack the java API binary from the aion_api repo into the released pack
  • For using the JavaAPI, the user need to unpack the file in the clientAPI folder inside the release pack. User will see the dependency libs, the clientAPI jar and the JAVA Doc.

Fixes Issue #166

Type of change

Insert x into the following checkboxes to confirm (eg. [x]):

  • Bug fix.
  • New feature.
  • Breaking change (a fix or feature that causes existing functionality to not work as expected).
  • Requires documentation update.

Testing

Please describe the tests you used to validate this pull request. Provide any relevant details for test configurations as well as any instructions to reproduce these results.

  • N/A

Verification

Insert x into the following checkboxes to confirm (eg. [x]):

  • I have self-reviewed my own code and conformed to the style guidelines of this project.
  • New and existing tests pass locally with my changes.
  • I have added tests for my fix or feature.
  • [] I have made appropriate changes to the corresponding documentation.
  • My code generates no new warnings.
  • Any dependent changes have been made.

@AionJayT AionJayT added the enhancement New feature or request label Jun 8, 2018
@AionJayT AionJayT added this to the v0.2.8 - University Peak milestone Jun 8, 2018
@AionJayT AionJayT changed the title Api pack java Api pack into release pack Jun 8, 2018
@AionJayT AionJayT changed the title java Api pack into release pack Java Api pack into release pack Jun 8, 2018
@AionJayT AionJayT changed the title Java Api pack into release pack Java Api pack into the release pack Jun 8, 2018
@AionJayT AionJayT merged commit f272658 into master-pre-merge Jun 13, 2018
@AionJayT AionJayT mentioned this pull request Jun 14, 2018
10 tasks
@AionJayT AionJayT deleted the api-pack branch June 14, 2018 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants